Skip to content

fix: Drive search view displays an empty state instead of the default file list (WPB-27353) - #5103

Open
ohassine wants to merge 6 commits into
developfrom
no-items-in-search-screen
Open

fix: Drive search view displays an empty state instead of the default file list (WPB-27353)#5103
ohassine wants to merge 6 commits into
developfrom
no-items-in-search-screen

Conversation

@ohassine

@ohassine ohassine commented Jul 27, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-27353


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Drive search view displays an empty state instead of the default file list before a search or filter is applied

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine
ohassine requested review from Garzas and sbakhtiarov and removed request for sbakhtiarov July 27, 2026 11:02
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.81%. Comparing base (7dadd23) to head (214185e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5103   +/-   ##
========================================
  Coverage    49.81%   49.81%           
========================================
  Files          665      665           
  Lines        24139    24139           
  Branches      3755     3755           
========================================
+ Hits         12025    12026    +1     
  Misses       10985    10985           
+ Partials      1129     1128    -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dadd23...214185e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 111 tests  +1   2 111 ✅ +1   2m 13s ⏱️ +22s
  229 suites ±0       0 💤 ±0 
  229 files   ±0       0 ❌ ±0 

Results for commit 214185e. ± Comparison against base commit 7dadd23.

♻️ This comment has been updated with latest results.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine
ohassine requested a review from saleniuk July 28, 2026 11:43
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants