Skip to content

feat(cells): show Pdf preview in conversation screen (WPB-20712) - #4318

Merged
ohassine merged 5 commits into
developfrom
pdf-preview
Oct 6, 2025
Merged

feat(cells): show Pdf preview in conversation screen (WPB-20712)#4318
ohassine merged 5 commits into
developfrom
pdf-preview

Conversation

@ohassine

@ohassine ohassine commented Sep 29, 2025

Copy link
Copy Markdown
Member
TaskWPB-20712 [Android] Show Pdf preview in conversation screen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Pdf files should have a preview in the chat

Screenshot_20250929_180622

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Sep 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.51%. Comparing base (f17adf2) to head (28a6c5d).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ssagetypes/multipart/standalone/PdfAssetPreview.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4318      +/-   ##
===========================================
- Coverage    47.52%   47.51%   -0.02%     
===========================================
  Files          517      518       +1     
  Lines        17706    17710       +4     
  Branches      2907     2909       +2     
===========================================
  Hits          8415     8415              
- Misses        8432     8436       +4     
  Partials       859      859              
Files with missing lines Coverage Δ
...ssagetypes/multipart/standalone/PdfAssetPreview.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f17adf2...28a6c5d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yamilmedina yamilmedina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small hardcoded dp we can change, that slipped through the PR :D

@ohassine
ohassine requested a review from saleniuk October 2, 2025 08:06
…el/messagetypes/multipart/standalone/PdfAssetPreview.kt

Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
@ohassine
ohassine enabled auto-merge October 6, 2025 08:24
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2025

Copy link
Copy Markdown

@ohassine
ohassine added this pull request to the merge queue Oct 6, 2025
Merged via the queue into develop with commit 39a439b Oct 6, 2025
15 of 16 checks passed
@ohassine
ohassine deleted the pdf-preview branch October 6, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants