You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@SantiagoDevRel
It seems to me that the .yml file is only needed if there are multiple pages in the category.
The Glossary page for example doesn't include it
Merging #6824 (5473e0b) into 4.x (4358140) will increase coverage by 4.66%.
Report is 181 commits behind head on 4.x.
The diff coverage is n/a.
❗ Current head 5473e0b differs from pull request most recent head 2b4e7c5. Consider uploading reports for the commit 2b4e7c5 to get more accurate results
You are right, @omahs i was thinking to have a folder to add later files to it, but in this case, a simple file is also fine since we can just add all the resources in 1 file. thanks. I think this is ready for review?
Btw, i'm not sure if its intuitive that you should click on the image to go the youtube video, maybe add the link in the title or something as well?
Or actually, if we create a Resources folder, we can include learning resources and current bounties/hackathons we are hosting?
so it will be like:
-Resources
--Learning resources
--Hackathon
or just include the current hackathon in the main 'resources' file or not include it at all (and only ,mention those events on twitter/discord), wdy think? @jdevcs
and also pls share ur opinion about this @omahs , would u like to see current hackathons for web3.js listed here or the docs is not the right place for it?
@SantiagoDevRel Just added the links to the title
For the hackathons, the downside is that it needs to be checked and updated regularly, will wait for @jdevcs answer too
@SantiagoDevRel Just added the links to the title For the hackathons, the downside is that it needs to be checked and updated regularly, will wait for @jdevcs answer too
you are right, for hackathons if this section is added it will need regular updates, may be add web3.js twitter badge for updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: create resources page #6821