This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add abiitem - #6778
Merged
Merged
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
luu-alex
marked this pull request as ready for review
January 31, 2024 19:12
luu-alex
requested review from
Muhammad-Altabba,
avkos and
jdevcs
as code owners
January 31, 2024 19:12
jdevcs
reviewed
Feb 1, 2024
Comment on lines
+116
to
+135
| [{ | ||
| anonymous: false, | ||
| constant: true, | ||
| inputs: [ | ||
| { | ||
| name: 'testMe', | ||
| type: 'uint256[3]' | ||
| }, | ||
| { | ||
| name: 'inputA', | ||
| type: 'tuple', | ||
| components: [ | ||
| { | ||
| name: 'a', | ||
| type: 'uint8' | ||
| }, | ||
| { | ||
| name: 'b', | ||
| type: 'uint8' | ||
| } |
Contributor
There was a problem hiding this comment.
I'll suggest to move this in fixtures file
jdevcs
approved these changes
Feb 5, 2024
avkos
approved these changes
Feb 5, 2024
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing exported type from 1.x to v4 for compatabiltiy
(#6678 )
https://github.com/web3/web3.js/blob/1.x/packages/web3-utils/types/index.d.ts#L218
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.