Expose RequestDestination "compression-dictionary" - #61480
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
July 22, 2026 16:55
Currently, Chromium uses "dictionary" as an internal destination. Align Chromium with spec PR [1], which uses string "compression-dictionary" instead. This is a web-exposed behavior change, so do that under a runtime flag. Also add a WPT test to check the new value, a more complex one is added in [2]. [1] whatwg/fetch#1854 [2] https://chromium-review.googlesource.com/c/chromium/src/+/8129944 NO_IFTTT=Both files updated, but the IfThen labels were wrong. Bug: 522338661, 40255884 Change-Id: I54b2047492ebc4d410351a83a10de8d0249b4b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8086393 Reviewed-by: Patrick Meenan <pmeenan@chromium.org> Commit-Queue: Frédéric Wang Nélar <fwang@igalia.com> Reviewed-by: Andrea Orru <andreaorru@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Ben Kelly <wanderview@meta.com> Cr-Commit-Position: refs/heads/main@{#1666398}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8086393
branch
from
July 22, 2026 16:55
0cc7f83 to
1d53b38
Compare
wpt-pr-bot
approved these changes
Jul 22, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Chromium uses "dictionary" as an internal destination. Align
Chromium with spec PR [1], which uses string "compression-dictionary"
instead. This is a web-exposed behavior change, so do that under a
runtime flag. Also add a WPT test to check the new value, a more
complex one is added in [2].
[1] whatwg/fetch#1854
[2] https://chromium-review.googlesource.com/c/chromium/src/+/8129944
NO_IFTTT=Both files updated, but the IfThen labels were wrong.
Bug: 522338661, 40255884
Change-Id: I54b2047492ebc4d410351a83a10de8d0249b4b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8086393
Reviewed-by: Patrick Meenan <pmeenan@chromium.org>
Commit-Queue: Frédéric Wang Nélar <fwang@igalia.com>
Reviewed-by: Andrea Orru <andreaorru@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Ben Kelly <wanderview@meta.com>
Cr-Commit-Position: refs/heads/main@{#1666398}