Return cached object from CryptoKey.algorithm getter#48923
Merged
servo-wpt-sync merged 1 commit intoNov 4, 2024
Conversation
4 tasks
wpt-pr-bot
approved these changes
Nov 1, 2024
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
servo-wpt-sync
force-pushed
the
servo_export_34092
branch
from
November 3, 2024 22:22
e97c07c to
2b9c256
Compare
This was referenced Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
CryptoKey.algorithmgetter which previously did not cache the returned object, but rather created a new one each time.Reviewed in servo/servo#34092