fix(core)!: apply URL parser mode to third-party packages - #1831
Draft
elecmonkey wants to merge 2 commits into
Draft
fix(core)!: apply URL parser mode to third-party packages#1831elecmonkey wants to merge 2 commits into
elecmonkey wants to merge 2 commits into
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
elecmonkey
marked this pull request as draft
August 6, 2026 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The URL parser mode is set on Rsbuild's built-in JavaScript rule, which does not match
node_modules. Anew URL()reference in a bundled third-party package thus falls back to Rspack's default handling, which resolves it through the module registry and injects the automatic public path runtime.Apply the same mode to third-party packages —
new-url-relativefor ESM, disabled for CJS — so their references become static relative URLs with no runtime.