feat(report): add synchronized Markdown report view - #2937
Merged
Conversation
yuyutaotao
approved these changes
Aug 6, 2026
The convertPlanToExecutable and createTypeQueryTask assertions matched the modelRuntime object with strict equality via toHaveBeenCalledWith. In the full CI suite the modelRuntime object carries extra CI-injected fields (e.g. an execution id), which made the exact match fail even though the core arguments were correct. Match on the core config/adapter shape with expect.objectContaining so the assertions stay meaningful while tolerating those extra fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm --dir apps/report test(16 files, 87 tests)MIDSCENE_SKIP_REPORT_TEMPLATE_INJECTION=1 pnpm exec nx build @midscene/core --skip-nx-cachepnpm --dir apps/report buildpnpm run lint