Eth invoke and ethereum tx refactoring - #657
Merged
nickeskov merged 10 commits intoFeb 7, 2022
Merged
Conversation
nickeskov
requested changes
Jan 27, 2022
| return nil, err | ||
| } | ||
| default: | ||
| return nil, errors.New("wrong sub transaction of invoke expression transaction") |
Collaborator
There was a problem hiding this comment.
Add info about type to the error message.
Comment on lines
+230
to
+231
| case *proto.InvokeScriptTxUnion: | ||
| switch subTx := invokeType.SubTx.(type) { |
Collaborator
There was a problem hiding this comment.
I think it's good idea to move all code from this case to new function.
Comment on lines
+293
to
+294
| case *proto.InvokeExpressionTxUnion: | ||
| switch subTx := invokeType.SubTx.(type) { |
Collaborator
There was a problem hiding this comment.
I think it's good idea to move all code from this case to new function.
nickeskov
self-requested a review
February 7, 2022 11:54
nickeskov
approved these changes
Feb 7, 2022
nickeskov
left a comment
nickeskov
left a comment
Collaborator
There was a problem hiding this comment.
Almost all issues were fixed, approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.