Fixed block finalization conversion in case of empty BLS signature. - #2192
Merged
nickeskov merged 2 commits intoAug 7, 2026
Merged
Conversation
Fixed finalization validation in case of no valid endorsements.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts deterministic finalization handling to support “conflicts-only” finalization votings (i.e., no valid endorsements), ensuring protobuf conversion and signature verification behave correctly when the aggregated BLS signature is absent/empty.
Changes:
- Refactors finalization processing to separate endorser collection from aggregated signature verification, and skips signature verification when there are no endorsers.
- Makes protobuf conversion treat an empty aggregated signature as “absent” (nil) to keep conversions symmetric with
FinalizationVoting.ToProtobuf. - Updates
FinalizationVoting.Validate()semantics and adds tests covering finalized height validation and protobuf round-trips.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/state/finalizer.go | Refactors endorser collection/signature verification; handles no-endorsement votings. |
| pkg/proto/protobuf_converters.go | Avoids parsing empty aggregated signatures; keeps signature pointer nil when absent. |
| pkg/proto/finalization.go | Adjusts finalized height validation behavior for conflicts-only votings. |
| pkg/proto/finalization_test.go | Adds tests for finalized height validation and protobuf round-trip stability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+122
to
+127
| if len(pks) == 0 { | ||
| return nil | ||
| } | ||
| if finalizationVoting.AggregatedEndorsementSignature == nil { | ||
| return errors.New("no aggregated signature in finalization voting with endorsements") | ||
| } |
Comment on lines
136
to
139
| // Finalized block height is meaningful only for endorsements, votings with conflicting endorsements | ||
| // only carry no finalized block height. | ||
| if len(f.EndorserIndexes) > 0 && f.FinalizedBlockHeight < genesisBlockHeight { | ||
| return fmt.Errorf("invalid finalization voting: finalized block height %d is less than genesis block height %d", |
nickeskov
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed finalization validation in case of no valid endorsements.