Skip to content

Ride version 9 added. - #1761

Merged
alexeykiselev merged 13 commits into
determenistic-finality-featurefrom
ride-v9
Sep 30, 2025
Merged

Ride version 9 added.#1761
alexeykiselev merged 13 commits into
determenistic-finality-featurefrom
ride-v9

Conversation

@alexeykiselev

Copy link
Copy Markdown
Collaborator

New ride function fillList added and tested.

New ride function fillList added and tested.
@alexeykiselev alexeykiselev added wip This is a WIP, should not be merged right away do not merge The PR is not ready to be merged labels Jul 17, 2025
…xity implemented and tested.

Old conversion functions refactored to use proper input and output limits.
RideV9 functions replaceFirst and replaceAll correct behavior on empty old string implemented.
Test naming changed to use fmt.Sprintf to support GoLand interface.
@alexeykiselev alexeykiselev removed wip This is a WIP, should not be merged right away do not merge The PR is not ready to be merged labels Jul 22, 2025
@nickeskov nickeskov added do not merge The PR is not ready to be merged awaiting-release Ready to be a part of a new release labels Aug 4, 2025
@alexeykiselev
alexeykiselev changed the base branch from master to determenistic-finality-feature September 22, 2025 09:56
@alexeykiselev alexeykiselev added the wip This is a WIP, should not be merged right away label Sep 22, 2025
@alexeykiselev alexeykiselev removed wip This is a WIP, should not be merged right away do not merge The PR is not ready to be merged labels Sep 26, 2025
Comment thread pkg/ride/functions_bytes.go Outdated
}
if l := len(s); l > maxBase58StringToDecode {
return nil, RuntimeError.Errorf("fromBase58: input is too long (%d), limit is %d", l, maxBase58StringToDecode)
if l := len(s); limits.input > 0 && l > limits.input /*maxBase58StringToDecode*/ {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@nickeskov nickeskov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeykiselev
alexeykiselev merged commit c01d622 into determenistic-finality-feature Sep 30, 2025
11 checks passed
@alexeykiselev
alexeykiselev deleted the ride-v9 branch September 30, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-release Ready to be a part of a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants