Skip to content

Change active and exact-active behavior for router-link - #136

Merged
posva merged 7 commits into
vuejs:masterfrom
posva:router/active-matching
Apr 14, 2020
Merged

Change active and exact-active behavior for router-link#136
posva merged 7 commits into
vuejs:masterfrom
posva:router/active-matching

Conversation

@posva

@posva posva commented Feb 28, 2020

Copy link
Copy Markdown
Member

Rendered

Make active matching more consistent by avoiding existing caveats by design

  • Is this breaking change bringing more value than the old behavior?
  • Are any of the alternatives listed more desirable?
  • Do you need the exact prop?

Please, vote with 👍 and 👎 if this is something you want or not

@posva posva added breaking change This RFC contains breaking changes or deprecations of old API. router labels Feb 28, 2020
Comment thread active-rfcs/0000-router-active-link.md Outdated
@posva

posva commented Mar 4, 2020

Copy link
Copy Markdown
Member Author

I added a few examples about the breaking change that should make this RFC clearer

@posva

posva commented Mar 12, 2020

Copy link
Copy Markdown
Member Author

I added a section about aliases to explain how they behave with the active behavior

@posva

posva commented Mar 20, 2020

Copy link
Copy Markdown
Member Author

Added a section about nested absolute aliases

@posva

posva commented Apr 7, 2020

Copy link
Copy Markdown
Member Author

This RFC is now in final comments stage. An RFC in final comments stage means that:

The core team has reviewed the feedback and reached consensus about the general direction of the RFC and believe that this RFC is a worthwhile addition to the framework.
Final comments stage does not mean the RFC's design details are final - we may still tweak the details as we implement it and discover new technical insights or constraints. It may even be further adjusted based on user feedback after it lands in an alpha/beta release.
If no major objections with solid supporting arguments have been presented after a week, the RFC will be merged and become an active RFC.

@posva posva added the final comments This RFC is in final comments period label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This RFC contains breaking changes or deprecations of old API. final comments This RFC is in final comments period router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants