Cover large mobile restore confirmations - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vrtmrz/obsidian-test-sessionfrom 0.1.0 to 0.2.0;Impact
This changes development tooling and the local real-Obsidian E2E suite only. It does not change production behaviour or the distributed plug-in bundle.
The large fixture is selected only by the restore-confirmation scenario. Other scenarios retain the original single-file plan. Both confirmation paths deliberately cancel before mutation; post-confirmation deletion semantics are outside this pull request.
Verification
npm run test:ui— 11 tests passed;npm run lintpassed;npm run prettyCheckpassed;npm run check:e2e:obsidianpassed;npm run test:e2e:obsidian:restore-confirmationpassed with Obsidian 1.12.7 on Linux arm64, including expanded normal-restore and delete-missing lists, safe-area checks, horizontal-overflow checks, and 44 CSS-pixel Close, Restore, and Cancel targets;npm run test:e2e:obsidian:wake-lockpassed, including backup and ZIP restore round-trip; andgit diff --checkpassed.