Preserve external Buffer view bounds - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExternalVaultFilesystem;_readBinary()with an offset Node Buffer returned by fakefsPromises.Root cause
The external filesystem adapter passed
buffer.bufferto the OW exact-view converter. Accessing the backing buffer first discarded the Buffer's visible range and could expose unrelated bytes from its allocation pool when the runtime returned an offset view.The defect and fix are reproduced deterministically by injecting an offset Buffer into the actual
ExternalVaultFilesystem._readBinary()method. No specific user incident or production data corruption has been confirmed.The storage accessor also depended on the factory module and concrete plug-in type, which pulled the complete plug-in and Svelte graph into an adapter-level test. The smaller structural context makes the adapter directly testable without changing its runtime policy. It remains a DiffZip-internal composition shape, not a proposed neutral filesystem API.
Impact
Fixed a potential issue where external filesystem reads could include bytes outside a Node Buffer's visible range when the runtime returned an offset view. The exact visible bytes are now returned. Root selection and external-backup path behaviour are unchanged.
Validation