reduce random max filesize in test#8934
Open
kshen0 wants to merge 1 commit into
Open
Conversation
This test neither exercises a codepath nor makes assertions that depend on absolute filesize. The [0, 10mb] spread for filesize * 100 default fc.assert runs was possibly causing timeouts when CI disk was under contention.
kshen0
marked this pull request as ready for review
July 18, 2026 00:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Possibly fixes test timeouts in https://app.circleci.com/pipelines/github/votingworks/vxsuite/27572/workflows/63d9ddfd-f77a-470f-8276-055e5a56bead/jobs/1286846
This test neither exercises a codepath nor makes assertions that depend on absolute filesize. The [0, 10mb] filesize spread for 100 runs of temp file writing/reading was possibly causing timeouts when CI disk was under contention.
Demo Video or Screenshot
N/A
Testing Plan
Existing tests