Skip to content

Fix bounded max partial state#8515

Merged
gatesn merged 1 commit into
developfrom
ngates/bounded-max
Jun 20, 2026
Merged

Fix bounded max partial state#8515
gatesn merged 1 commit into
developfrom
ngates/bounded-max

Conversation

@gatesn

@gatesn gatesn commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This is a breaking change to the serialized form of BoundedMax. The ZonedLayout change to persist these types hasn't been released yet though, so it is still safe to change for now.

In case of producing a bounded max value on top of another bounded max value we need to know if the original value was null or whether it became null after producing bound. It's safe to skip chunks in the first case but not in the second thus the zoned stats have to differentiate between the two

handle #8166

Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 11.85%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 11 improved benchmarks
❌ 3 regressed benchmarks
✅ 1567 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 155 µs 191.5 µs -19.03%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 170 µs 206.5 µs -17.68%
Simulation varbinview_large 112.5 µs 130.9 µs -14.09%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 186.1 ns +31.34%
Simulation baseline_eq[4, 65536] 243.4 µs 185.8 µs +31.03%
Simulation baseline_lt[4, 65536] 258.9 µs 201.1 µs +28.7%
Simulation baseline_eq[16, 65536] 288.3 µs 230.7 µs +24.96%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 246.4 ns +23.68%
Simulation baseline_lt[16, 65536] 303.6 µs 245.9 µs +23.48%
Simulation chunked_varbinview_opt_into_canonical[(1000, 10)] 220.8 µs 184.2 µs +19.87%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%
Simulation chunked_varbinview_canonical_into[(100, 100)] 258.9 µs 223.7 µs +15.71%
Simulation chunked_varbinview_opt_canonical_into[(100, 100)] 340 µs 305.4 µs +11.33%
Simulation chunked_varbinview_opt_into_canonical[(100, 100)] 391.2 µs 353.1 µs +10.8%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/bounded-max (c04f8cc) with develop (3f54d1f)

Open in CodSpeed

@gatesn gatesn added the changelog/fix A bug fix label Jun 19, 2026
@gatesn gatesn requested a review from robert3005 June 19, 2026 19:56
@gatesn gatesn marked this pull request as ready for review June 19, 2026 19:56
@gatesn gatesn requested a review from a team June 19, 2026 19:56
@gatesn gatesn added changelog/break A breaking API change and removed changelog/fix A bug fix labels Jun 19, 2026
@gatesn gatesn enabled auto-merge (squash) June 19, 2026 20:03
@AdamGS

AdamGS commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Can you add an explanation of the issue to the PR description?

@gatesn gatesn merged commit de60638 into develop Jun 20, 2026
76 of 79 checks passed
@gatesn gatesn deleted the ngates/bounded-max branch June 20, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants