feat(python): add cuda_enabled and vortex-data-cuda#8510
Draft
0ax1 wants to merge 2 commits into
Draft
Conversation
GPU support ships as a separate vortex-data-cuda package (imported as vortex_cuda); the base vortex-data wheel stays CPU-only. vortex.cuda_enabled() probes whether the companion is importable; the companion exposes cuda_available(). Cargo-workspace member (not uv), excluded from non-GPU CI. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Contributor
Author
|
@robert3005 & @gatesn Lemme know if this directionally makes sense. |
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | decompress_rd[f64, (10000, 0.01)] |
108.9 µs | 139.2 µs | -21.77% |
| ❌ | Simulation | decompress_rd[f64, (10000, 0.1)] |
109.2 µs | 139.5 µs | -21.74% |
| ❌ | Simulation | decompress_rd[f64, (10000, 0.0)] |
108.9 µs | 139.2 µs | -21.74% |
| ❌ | Simulation | decompress_rd[f32, (100000, 0.0)] |
496.1 µs | 583.9 µs | -15.04% |
| ❌ | Simulation | decompress_rd[f32, (10000, 0.01)] |
78.2 µs | 90.7 µs | -13.81% |
| ❌ | Simulation | decompress_rd[f32, (10000, 0.1)] |
78.2 µs | 90.7 µs | -13.8% |
| ❌ | Simulation | decompress_rd[f32, (10000, 0.0)] |
78.7 µs | 91.2 µs | -13.77% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 186.1 ns | +31.34% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 246.4 ns | +23.68% |
| ⚡ | Simulation | take_10k_first_chunk_only |
251.3 µs | 206.5 µs | +21.7% |
| ⚡ | Simulation | decompress_rd[f64, (100000, 0.1)] |
1,020.9 µs | 842.8 µs | +21.13% |
| ⚡ | Simulation | decompress_rd[f64, (100000, 0.01)] |
1,020.9 µs | 842.8 µs | +21.13% |
| ⚡ | Simulation | take_10k_dispersed |
264.8 µs | 220.2 µs | +20.28% |
| ⚡ | Simulation | decompress_rd[f32, (100000, 0.1)] |
583 µs | 495.5 µs | +17.67% |
| ⚡ | Simulation | decompress_rd[f32, (100000, 0.01)] |
583 µs | 495.5 µs | +17.67% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
427.8 ns | 369.4 ns | +15.79% |
| ⚡ | Simulation | patched_take_10k_adversarial |
259.7 µs | 229.6 µs | +13.13% |
| ⚡ | Simulation | patched_take_10k_first_chunk_only |
282.9 µs | 252.7 µs | +11.97% |
| ⚡ | Simulation | patched_take_10k_dispersed |
297 µs | 266.8 µs | +11.33% |
| ⚡ | Simulation | eq_i64_constant |
317.9 µs | 288 µs | +10.4% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ad/pyvortex-cudf (671cae2) with develop (9814173)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPU support ships as a separate vortex-data-cuda package (imported as vortex_cuda); the base vortex-data wheel stays CPU-only.
vortex.cuda_enabledprobes whether the companion is importable; the companion exposescuda_available.