Skip to content

fix(sequence): fall back to canonical cast when params can't fit target #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
changjoon-park wants to merge 1 commit into from
Closed

fix(sequence): fall back to canonical cast when params can't fit target #7630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions encodings/sequence/src/compute/cast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,20 @@ impl CastReduce for Sequence {
Some(ScalarValue::Primitive(array.multiplier())),
)?;

let new_base_scalar =
base_scalar.cast(&DType::Primitive(*target_ptype, Nullability::NonNullable))?;
let new_multiplier_scalar = multiplier_scalar
.cast(&DType::Primitive(*target_ptype, Nullability::NonNullable))?;
let target_scalar_dtype = DType::Primitive(*target_ptype, Nullability::NonNullable);

// If either the base or multiplier cannot be represented in the target
// type (e.g., a negative multiplier with an unsigned target), fall back
// to the canonical cast path by returning `Ok(None)`. That path decodes
// individual values and casts them one by one, which correctly succeeds
// whenever all produced values fit the target type even if the stored
// parameters do not.
let Ok(new_base_scalar) = base_scalar.cast(&target_scalar_dtype) else {
return Ok(None);
};
let Ok(new_multiplier_scalar) = multiplier_scalar.cast(&target_scalar_dtype) else {
return Ok(None);
};

// Extract PValues from the casted scalars
let new_base = new_base_scalar
Expand Down Expand Up @@ -186,11 +196,7 @@ mod tests {
#[rstest]
#[case::i32(Sequence::try_new_typed(0i32, 1i32, Nullability::NonNullable, 5).unwrap())]
#[case::u64(Sequence::try_new_typed(1000u64, 100u64, Nullability::NonNullable, 4).unwrap())]
// TODO(DK): SequenceArray does not actually conform. You cannot cast this array to u8 even
// though all its values are representable therein.
//
// #[case::negative_step(Sequence::try_new_typed(100i32, -10i32, Nullability::NonNullable,
// 5).unwrap())]
#[case::negative_step(Sequence::try_new_typed(100i32, -10i32, Nullability::NonNullable, 5).unwrap())]
#[case::single(Sequence::try_new_typed(42i64, 0i64, Nullability::NonNullable, 1).unwrap())]
#[case::constant(Sequence::try_new_typed(
100i32,
Expand Down