Skip to content

cross-arm-none-eabi-gdb: update to 12.1, fix build for gcc-12#40887

Merged
paper42 merged 1 commit into
void-linux:masterfrom
7r3nzy:cross-arm-none-eabi-gdb
Dec 4, 2022
Merged

cross-arm-none-eabi-gdb: update to 12.1, fix build for gcc-12#40887
paper42 merged 1 commit into
void-linux:masterfrom
7r3nzy:cross-arm-none-eabi-gdb

Conversation

@7r3nzy

@7r3nzy 7r3nzy commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: NO

Local build testing

  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch (cross built from x86-64)

checksum=cccfcc407b20d343fb320d4a9a2110776dd3165118ffd41f4b1b162340333f94
checksum=0e1793bf8f2b54d53f46dea84ccfd446f48f81b297b28c4f7fc017b818d69fed
make_check=no # See gdb/template.
patch_args="-Np1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line shouldn't be necessary now, could you remove it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paper42 I have removed the patch file as well

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still applies, no? Is it fixed upstream in a different way?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So actually I only made sure that it still builds without the patch in gcc12 and current gcc

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess this is only required for mips and other gdb packages still have it, so if you are not sure it's not required anymore, please don't remove it.

cc @unspecd

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah Okay

@7r3nzy 7r3nzy force-pushed the cross-arm-none-eabi-gdb branch from b34cae0 to 1794994 Compare December 4, 2022 13:29
@7r3nzy 7r3nzy requested a review from paper42 December 4, 2022 13:31
@7r3nzy 7r3nzy force-pushed the cross-arm-none-eabi-gdb branch from 1794994 to 0f88196 Compare December 4, 2022 14:31
@paper42 paper42 force-pushed the cross-arm-none-eabi-gdb branch from 0f88196 to b1726c2 Compare December 4, 2022 14:47
@paper42 paper42 merged commit b1726c2 into void-linux:master Dec 4, 2022
@riddicc

riddicc commented Oct 26, 2023

Copy link
Copy Markdown

uhm? why is cross-arm-none-eabi-gcc still 9.3? is there something wrong with ur automatic proceedings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants