cross-arm-none-eabi-gdb: update to 12.1, fix build for gcc-12#40887
Merged
Conversation
35a3010 to
b34cae0
Compare
47 tasks
paper42
reviewed
Dec 4, 2022
| checksum=cccfcc407b20d343fb320d4a9a2110776dd3165118ffd41f4b1b162340333f94 | ||
| checksum=0e1793bf8f2b54d53f46dea84ccfd446f48f81b297b28c4f7fc017b818d69fed | ||
| make_check=no # See gdb/template. | ||
| patch_args="-Np1" |
Contributor
There was a problem hiding this comment.
this line shouldn't be necessary now, could you remove it?
Contributor
Author
There was a problem hiding this comment.
@paper42 I have removed the patch file as well
Contributor
There was a problem hiding this comment.
It still applies, no? Is it fixed upstream in a different way?
Contributor
Author
There was a problem hiding this comment.
So actually I only made sure that it still builds without the patch in gcc12 and current gcc
Contributor
There was a problem hiding this comment.
I would guess this is only required for mips and other gdb packages still have it, so if you are not sure it's not required anymore, please don't remove it.
cc @unspecd
b34cae0 to
1794994
Compare
1794994 to
0f88196
Compare
0f88196 to
b1726c2
Compare
|
uhm? why is cross-arm-none-eabi-gcc still 9.3? is there something wrong with ur automatic proceedings? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing