Skip to content

cpp-hocon: add shared library, disable tests build#40645

Merged
sgn merged 3 commits into
void-linux:masterfrom
paper42:cpp-hocon
Dec 3, 2022
Merged

cpp-hocon: add shared library, disable tests build#40645
sgn merged 3 commits into
void-linux:masterfrom
paper42:cpp-hocon

Conversation

@paper42

@paper42 paper42 commented Nov 20, 2022

Copy link
Copy Markdown
Contributor

tests do not build with gcc 12

Testing the changes

  • I tested the changes in this PR: briefly

@ghost

ghost commented Nov 23, 2022

Copy link
Copy Markdown

Is this patch suitable for you?

diff --git a/srcpkgs/facter/template b/srcpkgs/facter/template
index dc01c966a0..dbf8bd0e71 100644
--- a/srcpkgs/facter/template
+++ b/srcpkgs/facter/template
@@ -24,7 +24,7 @@ pre_configure() {
 
 post_build() {
 	# fixup vendor_ruby usr/lib{32,64} install path to always use usr/lib
-	vsed -i build/lib/cmake_install.cmake -e "s;lib32;lib;g" -e "s;lib64;lib;g"
+	vsed -i build/lib/cmake_install.cmake -e "s;lib[0-9][0-9];;g"
 }
 
 facter-devel_package() {

Tests seem to be failing here:

=> facter-3.14.16_5: running post_build ...
=> facter-3.14.16_5: running do_check ...
[0/1] Running tests...
Test project /builddir/facter-3.14.16/build
    Start 1: libfacter tests
1/3 Test #1: libfacter tests ..................***Failed    5.57 sec

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libfacter_test is a Catch v1.10.0 host application.
Run with -? for options

-------------------------------------------------------------------------------
Scenario: using a double fact value
      When: serialized to YAML
      Then: it should have the same value
-------------------------------------------------------------------------------
/builddir/facter-3.14.16/lib/tests/facts/double_value.cc:27
...............................................................................

/builddir/facter-3.14.16/lib/tests/facts/double_value.cc:30: FAILED:
  REQUIRE( string(emitter.c_str()) == "42.4242" )
with expansion:
  "42.424199999999999" == "42.4242"

-------------------------------------------------------------------------------
Scenario: using the filesystem resolver
      When: populating facts
      Then: non-tmpfs mounts should exist
-------------------------------------------------------------------------------
/builddir/facter-3.14.16/lib/tests/facts/linux/filesystem_resolver.cc:37
...............................................................................

/builddir/facter-3.14.16/lib/tests/facts/linux/filesystem_resolver.cc:38: FAILED:
  REQUIRE( facts.query<facter::facts::map_value>("mountpoints./") )
with expansion:
  NULL

===============================================================================
test cases:    73 |    71 passed | 2 failed
assertions: 12054 | 12052 passed | 2 failed


    Start 2: libfacter specs
2/3 Test #2: libfacter specs ..................   Passed    4.76 sec
    Start 3: facter smoke
3/3 Test #3: facter smoke .....................   Passed    0.51 sec

67% tests passed, 1 tests failed out of 3

Total Test time (real) =  10.95 sec

The following tests FAILED:
	  1 - libfacter tests (Failed)
Errors while running CTest
FAILED: CMakeFiles/test.util 
cd /builddir/facter-3.14.16/build && /usr/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.
=> ERROR: facter-3.14.16_5: do_check: '${make_check_pre} ${make_cmd} ${makejobs} ${make_check_args} ${make_check_target}' exited with 1
=> ERROR:   in do_check() at common/build-style/cmake.sh:127

Upstream does not have fixes for them in the "3.*" branch.

@sgn

sgn commented Nov 25, 2022

Copy link
Copy Markdown
Member

test can be built again.

@sgn sgn merged commit ae77199 into void-linux:master Dec 3, 2022
zen0bit pushed a commit to oSoWoSo/VUR that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants