Skip to content

offlineimap: update to 8.0.0; remove dispensable py2 deps#38781

Merged
leahneukirchen merged 5 commits into
void-linux:masterfrom
icp1994:offlineimap
Sep 4, 2022
Merged

offlineimap: update to 8.0.0; remove dispensable py2 deps#38781
leahneukirchen merged 5 commits into
void-linux:masterfrom
icp1994:offlineimap

Conversation

@icp1994

@icp1994 icp1994 commented Aug 19, 2022

Copy link
Copy Markdown
Member

Testing the changes

  • I tested the changes in this PR: NO

Local build testing

  • I built this PR locally for my native architecture, x86_64

This update migrates the package to python 3. Two of the python 2 dependencies under the old full-deptree don't have any more dependent packages. I removed one of them outright. For the other, which provided a python 3 counterpart as subpackage, removed the python 2 package and converted the python 3 symlinked package to be its own module.

I DID NOT do any significant runtime testing on the updated offlineimap package expect for installing and running --version, --help etc.

Inessential python2 remnant
Inessential python2 remnant
@classabbyamp classabbyamp added needs-testing Testing a PR or reproducing an issue needed remove Package removal labels Aug 19, 2022
@leahneukirchen

Copy link
Copy Markdown
Member

Do not merge without my approval please.

@leahneukirchen

Copy link
Copy Markdown
Member

GitHub Actions doesn't do IPv6, please disable these tests too.

@icp1994

icp1994 commented Aug 19, 2022

Copy link
Copy Markdown
Member Author

Maybe I got the commit order wrong? Seemed okay to me but some builds are confused about not finding the imaplib2 lib while others work fine :/

@leahneukirchen

Copy link
Copy Markdown
Member

python3-imaplib2 needs to be in hostmakedepends too if it's needed during build

@icp1994

icp1994 commented Aug 19, 2022

Copy link
Copy Markdown
Member Author

Ah, everything under $depends of offlineimap were needed for building too. But I never noticed anything locally since they were always getting pulled in for checkdepends. That's my guess since every CI with test passed the build.

@leahneukirchen

Copy link
Copy Markdown
Member

Used it for three days, seems to work fine and even is a bit faster.

@leahneukirchen leahneukirchen removed the needs-testing Testing a PR or reproducing an issue needed label Aug 28, 2022
@classabbyamp

Copy link
Copy Markdown
Member

@leahneukirchen still working well? can this be merged?

@leahneukirchen leahneukirchen merged commit a6d6fa2 into void-linux:master Sep 4, 2022
@icp1994 icp1994 deleted the offlineimap branch September 4, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remove Package removal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants