Skip to content

ddgtk: fixes for vte, latest meson, py module name, additional deps#12710

Merged
pullmoll merged 2 commits into
void-linux:masterfrom
reback00:ddgtk-v0_1-fix-branch
Jun 30, 2019
Merged

ddgtk: fixes for vte, latest meson, py module name, additional deps#12710
pullmoll merged 2 commits into
void-linux:masterfrom
reback00:ddgtk-v0_1-fix-branch

Conversation

@reback00

Copy link
Copy Markdown
Contributor

Changes:

  1. Added additional dependencies against build warnings [template]
  2. Updated for latest meson [patch]
  3. Updated for latest python module (instead of deprecated python3 module, used the new python module, according to: https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types) [patch]
  4. Fixed breakage of write functionality due to recent changes in Vte python bindings (Explanation here: Сustom commands - does not work Guake/guake#1243 (comment)) [patch]

#4 raised an error like this below which has been fixed:

Traceback (most recent call last):
  File "/usr/local/share/ddgtk/ddgtk/main.py", line 154, in on_confirm_ok_clicked
    self.dd()
  File "/usr/local/share/ddgtk/ddgtk/main.py", line 125, in dd
    self.terminal.feed_child(clear,-1)
TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)

@Gottox

Gottox commented Jun 27, 2019

Copy link
Copy Markdown
Member
... + other changes ...

What are those other changes? Please update the commit message :)

@reback00 reback00 force-pushed the ddgtk-v0_1-fix-branch branch from f9cf4bd to 8705d7f Compare June 27, 2019 14:24
@reback00

reback00 commented Jun 27, 2019

Copy link
Copy Markdown
Contributor Author
... + other changes ...

What are those other changes? Please update the commit message :)

Oh! I thought adding all of them would make the commit message/title bigger. So I added them in the pull request message. No problem, this time I added them in the title. Hope it works. :)

ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name

@reback00

reback00 commented Jun 27, 2019

Copy link
Copy Markdown
Contributor Author

The 2 builds ARCH=x86_64 BOOTSTRAP=x86_64 and ARCH=armv7l BOOTSTRAP=x86_64 failed because of a Bad Gateway error. I did not change any code in my last commit, so it should've passed. Is it an error on Travis CI's end?
Should I do anything further?

log:

=> ddgtk-0.1_2: fetching distfile '0.1.tar.gz'...
https://github.com/gort818/ddgtk/archive/0.1.tar.gz: Bad Gateway
=> ERROR: ddgtk-0.1_2: failed to fetch 0.1.tar.gz.
...
Done. Your build exited with 1.

source
another

@reback00 reback00 changed the title ddgtk: fixes for recent vte python bindings + other changes ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name Jun 27, 2019
@reback00 reback00 force-pushed the ddgtk-v0_1-fix-branch branch from 8705d7f to 40eaf84 Compare June 27, 2019 16:58
@pullmoll

Copy link
Copy Markdown
Member

@Duncaen wanted you to change the commit message, i.e. the title < 72 chars and the details in the message body. The PR title is more or less irrelevant, but should usually match the first line of the commit message.
In short do a git commit --amend and fix the title, leave one empty line, and fille body of the message with what's listed in this PR. The do a git push -f to your branch.
HTH :)

@reback00 reback00 force-pushed the ddgtk-v0_1-fix-branch branch from 40eaf84 to 325ec2a Compare June 28, 2019 21:13
@reback00 reback00 changed the title ddgtk: added fixes for recent vte python bindings, added additional deps, updated for latest meson, adjusted to new python module name ddgtk: fixes for vte, latest meson, py module name, additional deps Jun 28, 2019
@reback00

Copy link
Copy Markdown
Contributor Author

@pullmoll Thanks. I think I get it now. I have changed the commit message and added a smaller title and also added the list of changes after a blank line. Also, changed the title of the PR according to the first line of the commit message.

I gotta say, you guys are more helpful than the Arch Linux guys! They like to scream at people for not getting things right and link adamantly to wikis without explaining stuff. Happy to be a part of Void Linux.

1. [template] Added additional dependencies against build warnings
2. [patch] Updated for latest meson
3. [patch] Updated for latest python module name (instead of deprecated `python3` module, changed to `python` module, according to: https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types )
4. [patch] Fixed breakage of write functionality due to recent changes in Vte python bindings. Used to raise a `TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)` error which has been fixed. (Explanation here: Guake/guake#1243 (comment) )
@pullmoll pullmoll merged commit 3ee0244 into void-linux:master Jun 30, 2019
@pullmoll

Copy link
Copy Markdown
Member

I just now saw there were 2 commits. In the future please squash commits to one per package, i.e. git rebase -i master and squash or fixup the 2nd, 3rd etc. commit depending on whether you want to combine and edit the final commit message or not, then do the git push -f. You can always git commit --amend the latest commit.

@reback00

Copy link
Copy Markdown
Contributor Author

Ok. Thanks.

@reback00 reback00 deleted the ddgtk-v0_1-fix-branch branch October 19, 2019 18:22
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants