ddgtk: fixes for vte, latest meson, py module name, additional deps#12710
Conversation
What are those other changes? Please update the commit message :) |
f9cf4bd to
8705d7f
Compare
Oh! I thought adding all of them would make the commit message/title bigger. So I added them in the pull request message. No problem, this time I added them in the title. Hope it works. :)
|
|
The 2 builds log: |
8705d7f to
40eaf84
Compare
|
@Duncaen wanted you to change the commit message, i.e. the title < 72 chars and the details in the message body. The PR title is more or less irrelevant, but should usually match the first line of the commit message. |
40eaf84 to
325ec2a
Compare
|
@pullmoll Thanks. I think I get it now. I have changed the commit message and added a smaller title and also added the list of changes after a blank line. Also, changed the title of the PR according to the first line of the commit message. I gotta say, you guys are more helpful than the Arch Linux guys! They like to scream at people for not getting things right and link adamantly to wikis without explaining stuff. Happy to be a part of Void Linux. |
1. [template] Added additional dependencies against build warnings 2. [patch] Updated for latest meson 3. [patch] Updated for latest python module name (instead of deprecated `python3` module, changed to `python` module, according to: https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types ) 4. [patch] Fixed breakage of write functionality due to recent changes in Vte python bindings. Used to raise a `TypeError: Vte.Terminal.feed_child() takes exactly 2 arguments (3 given)` error which has been fixed. (Explanation here: Guake/guake#1243 (comment) )
|
I just now saw there were 2 commits. In the future please squash commits to one per package, i.e. |
|
Ok. Thanks. |
Changes:
python3module, used the newpythonmodule, according to: https://mesonbuild.com/Release-notes-for-0-48-0.html#dependencyversion-now-applies-to-all-dependency-types) [patch]#4 raised an error like this below which has been fixed: