fix(mergeConfig): don't recreate server.hmr.server instance - #17763
Merged
Conversation
|
|
bluwy
approved these changes
Jul 30, 2024
bluwy
left a comment
bluwy
left a comment
Member
There was a problem hiding this comment.
I also think it's fine to keep it simple and handle this specific case for now. We can revisit checking classes next time.
patak-cat
approved these changes
Jul 30, 2024
patak-cat
added
the
p3-minor-bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
mergeConfigfunction recursively goes through objects and overrides them. This works for the most part, except for theserver.hmr.serverproperty which is aServerclass/object.The problem is that the
mergeConfigfunction treats it like a normal JS object and effectively clones it. This turns it into a standard object which doesn't work. And it also breaks reference to the object.We either need to modify the
isObjectfunction to check for classes, or for now, I've added an if statement to handle the special case, following the other precedence.