Skip to content

fix(core): observe dock sidebar size in the popup's own realm - #521

Closed
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/dock-sidebar-popup-resize-realm
Closed

fix(core): observe dock sidebar size in the popup's own realm#521
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/dock-sidebar-popup-resize-realm

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Description

In popup dock mode, resizing the popup window does not update the dock sidebar group rail immediately.

When shrinking the popup window, the group rail does not collapse into the overflow ("more") icon as expected. when enlarging the popup window, the hidden icons do not restore immediately. the state is only updated after moving the mouse into the host page.

Linked Issues

Additional context

@pkg-pr-new

pkg-pr-new Bot commented Aug 8, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@521

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@521

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@521

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@521

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@521

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@521

commit: a130825

@SaKaNa-Y

SaKaNa-Y commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

Most functionality is now working properly in popup mode. However, the Vite and Rolldown Modules Graph feature still has a minor issue when running in popup mode.

@antfubot

Copy link
Copy Markdown
Collaborator

Thanks for this fix!

As of #529, the client UI previously at packages/core/src/client/** (webcomponents, dock, floating popover, json-render, inject runtime, etc.) has moved out of this repo. It now lives upstream in devframe (@devframes/hub-ui / @devframes/json-render-ui), and this repo consumes it as a published dependency instead of owning the source.

Since this PR's changes target code that no longer lives here, we're labeling it devframe. We've opened devframes/devframe#207 to port this fix upstream and credit you as the original author — thank you for the work, and sorry for the churn from the migration. Feel free to pick up the port yourself against devframe (linking back to this PR) if you'd like; otherwise we'll route it through the linked issue.

@antfubot antfubot added the devframe Affected by the devframe/hub-ui migration; fix belongs upstream in devframe label Aug 14, 2026
@antfu antfu closed this Aug 14, 2026
@SaKaNa-Y
SaKaNa-Y deleted the fix/dock-sidebar-popup-resize-realm branch August 14, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devframe Affected by the devframe/hub-ui migration; fix belongs upstream in devframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants