Skip to content

Throw for empty or incomplete generateStaticParams results with output: export#95969

Merged
devjiwonchoi merged 3 commits into
jiwon/gsp-return-validationfrom
jiwon/gsp-export-diagnostics
Jul 23, 2026
Merged

Throw for empty or incomplete generateStaticParams results with output: export#95969
devjiwonchoi merged 3 commits into
jiwon/gsp-return-validationfrom
jiwon/gsp-export-diagnostics

Conversation

@devjiwonchoi

@devjiwonchoi devjiwonchoi commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Tip

This PR is best reviewed commit by commit.

Why?

With output: 'export', an empty array or incomplete params can be reported as a missing generateStaticParams function, even when the function exists.

How?

Stacked on #95968.

Supersedes #95388.

Co-authored-by: SukkaW isukkaw@gmail.com

@github-actions

github-actions Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: b8602c4

@github-actions

github-actions Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 811ms 811ms ✓ ▂▂██▂
Cold (Ready in log) 776ms 778ms ✓ ▁▁██▂
Cold (First Request) 1.280s 1.270s ✓ ▂▁██▂
Warm (Listen) 812ms 811ms ✓ ▂▂██▂
Warm (Ready in log) 778ms 781ms ✓ ▂▁██▂
Warm (First Request) 1.270s 1.256s ✓ ▁▁██▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 811ms 812ms ✓ ████▁
Cold (Ready in log) 772ms 774ms ✓ █▅▇▇▁
Cold (First Request) 3.267s 3.264s ✓ ▂▃▂█▁
Warm (Listen) 813ms 812ms ✓ ████▁
Warm (Ready in log) 786ms 775ms ✓ █▅▄█▁
Warm (First Request) 3.390s 3.352s ✓ ▂▁▁█▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.119s 5.069s ✓ ▁▁██▂
Cached Build 5.139s 5.152s ✓ ▂▁██▃
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 25.484s 25.234s ✓ ▂▃▃█▁
Cached Build 25.453s 25.830s ✓ ▂▅▅▆▁
node_modules Size 527 MB 527 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
03v9blsp0psjq.js gzip 71.1 kB N/A -
0a-p0meqxynjz.js gzip 10.3 kB N/A -
0avtke4yefj4-.js gzip 13.1 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0ftk80yrk_4m7.js gzip 157 B N/A -
0jv3uf2xh20zv.js gzip 156 B N/A -
0ka6ludg5k7ok.js gzip 156 B N/A -
0lwvajz2zibmk.js gzip 169 B N/A -
0pt5of3ch6d2u.js gzip 13.6 kB N/A -
0x2gfdot0f70e.js gzip 154 B N/A -
0xnsdo-6y9r3k.js gzip 5.72 kB N/A -
0yi7is8u4covm.js gzip 8.77 kB N/A -
11i_pcs9fzvma.js gzip 155 B N/A -
13xnpbucchsa6.js gzip 156 B N/A -
16dqh63w3ub5v.js gzip 157 B N/A -
1cddq5g599mjv.js gzip 161 B N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1gkbj5r69nc7h.js gzip 155 B N/A -
1h--jlxvyq3f_.js gzip 160 B N/A -
1lsl-hvtjoz38.js gzip 7.4 kB N/A -
1prv-wg6jgtt2.js gzip 8.77 kB N/A -
1t47vod02e_4a.js gzip 8.75 kB N/A -
1tf1phijqlx9j.js gzip 220 B 220 B ✓
1tw002sq5bo4l.js gzip 10 kB N/A -
1wlerik1n7zbr.js gzip 8.7 kB N/A -
1yg03l4l8kq1u.js gzip 154 B N/A -
28koph4jjzmen.js gzip 45.2 kB N/A -
2lviwqiqxm904.js gzip 3.52 kB N/A -
2pevdqjpbf3xk.js gzip 9.45 kB N/A -
2qd2anu9eizlz.js gzip 8.75 kB N/A -
2sv39ae5_8vfj.js gzip 8.81 kB N/A -
2utx6n7w65xqa.js gzip 8.7 kB N/A -
3-ukivglqkfeq.js gzip 8.78 kB N/A -
325xisqrylugu.js gzip 450 B N/A -
36r08tl29515j.js gzip 65.6 kB N/A -
3jc9ghvds1spf.js gzip 2.29 kB N/A -
3juwkvkgvywfe.js gzip 10.6 kB N/A -
3kbove7q58uqh.js gzip 13.2 kB N/A -
3qn7vntp30gaj.js gzip 1.47 kB N/A -
43gt_g3whvz4p.js gzip 157 B N/A -
turbopack-05..x8se.js gzip 3.81 kB N/A -
turbopack-0d..u8n2.js gzip 3.8 kB N/A -
turbopack-0u.._wu0.js gzip 3.81 kB N/A -
turbopack-1h..cctz.js gzip 3.81 kB N/A -
turbopack-1u..uctr.js gzip 3.78 kB N/A -
turbopack-2f..rc2p.js gzip 3.81 kB N/A -
turbopack-2i.._8tj.js gzip 3.8 kB N/A -
turbopack-2j..ds3q.js gzip 3.81 kB N/A -
turbopack-2x..j7tp.js gzip 3.82 kB N/A -
turbopack-31..0owl.js gzip 3.81 kB N/A -
turbopack-34..cuoy.js gzip 3.81 kB N/A -
turbopack-36..7fxt.js gzip 3.81 kB N/A -
turbopack-3x..rb-n.js gzip 3.81 kB N/A -
turbopack-44..7z5z.js gzip 3.8 kB N/A -
00ubmvikoy9w3.js gzip N/A 158 B -
030a1njeh5b77.js gzip N/A 10 kB -
032hrjhfkfc_a.js gzip N/A 158 B -
09e7r3p7xf6ey.js gzip N/A 162 B -
0c-4upnoqdx_x.js gzip N/A 168 B -
0ot0qt5np20h7.js gzip N/A 8.78 kB -
0u1wgjzz3gp10.js gzip N/A 156 B -
0yf8sz8kvzg4x.js gzip N/A 156 B -
0zfiixyrx7iap.js gzip N/A 157 B -
0zypcuib0m4y0.js gzip N/A 163 B -
1-qxxhh8-axib.js gzip N/A 45.2 kB -
10zsd2f1xhitb.js gzip N/A 65.6 kB -
12m9rr7_7cexd.js gzip N/A 8.7 kB -
186r3y_rfvr0b.js gzip N/A 8.78 kB -
19v97848yrjp7.js gzip N/A 8.81 kB -
1cvaplh7gszio.js gzip N/A 157 B -
1l-r8anpd80-7.js gzip N/A 71.1 kB -
1nd_0rwgz2ozk.js gzip N/A 9.45 kB -
1oi9pltr_e10m.js gzip N/A 10.6 kB -
1rd9tzqgzsz2w.js gzip N/A 8.77 kB -
1rq1g_cwv642d.js gzip N/A 10.3 kB -
1uojw_uabeg93.js gzip N/A 450 B -
1w-7lusgyl81y.js gzip N/A 8.7 kB -
1y1gr1ju71ajb.js gzip N/A 156 B -
2-kdoq-jy_crq.js gzip N/A 7.41 kB -
21h56wdn9zddo.js gzip N/A 8.75 kB -
2lg10omv7xu14.js gzip N/A 3.52 kB -
2mrwb11q5sxde.js gzip N/A 158 B -
2ovff1533zvno.js gzip N/A 13.2 kB -
2s4z8jy0z7v93.js gzip N/A 1.46 kB -
2vxbuefx8w-6i.js gzip N/A 156 B -
2y6gb5bs4mnam.js gzip N/A 8.75 kB -
3_jif1do29dzi.js gzip N/A 154 B -
341h71ln1jpl3.js gzip N/A 2.29 kB -
34ttpt_n7605h.js gzip N/A 5.72 kB -
36ckfq9o-ys-a.js gzip N/A 13.1 kB -
3vdh6_u50pu5t.js gzip N/A 13.6 kB -
turbopack-0_..mu2p.js gzip N/A 3.81 kB -
turbopack-0g..ecs7.js gzip N/A 3.8 kB -
turbopack-0l..-gfw.js gzip N/A 3.82 kB -
turbopack-0x..bwoh.js gzip N/A 3.81 kB -
turbopack-12..bane.js gzip N/A 3.81 kB -
turbopack-15..7p35.js gzip N/A 3.81 kB -
turbopack-1l..lxas.js gzip N/A 3.8 kB -
turbopack-1s..3rf-.js gzip N/A 3.78 kB -
turbopack-1x..6i4w.js gzip N/A 3.81 kB -
turbopack-22..hey9.js gzip N/A 3.81 kB -
turbopack-28..ue4z.js gzip N/A 3.81 kB -
turbopack-2h..5bop.js gzip N/A 3.81 kB -
turbopack-36..s8xy.js gzip N/A 3.8 kB -
turbopack-3q..fot4.js gzip N/A 3.81 kB -
Total 448 kB 448 kB ⚠️ +52 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 776 B 775 B ✓
Total 776 B 775 B ✅ -1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 434 B 432 B ✓
Total 434 B 432 B ✅ -2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
3322-HASH.js gzip 63.7 kB N/A -
4191.HASH.js gzip 169 B N/A -
7920-HASH.js gzip 4.68 kB N/A -
9784-HASH.js gzip 5.63 kB N/A -
b1ad9f4c-HASH.js gzip 62.9 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 254 B 254 B ✓
main-HASH.js gzip 40 kB 40 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
3577.HASH.js gzip N/A 168 B -
578-HASH.js gzip N/A 64.4 kB -
8590-HASH.js gzip N/A 5.61 kB -
9750-HASH.js gzip N/A 4.69 kB -
a8984546-HASH.js gzip N/A 62.9 kB -
Total 239 kB 239 kB ⚠️ +637 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 181 B 182 B ✓
css-HASH.js gzip 334 B 331 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 255 B 253 B ✓
head-HASH.js gzip 349 B 351 B ✓
hooks-HASH.js gzip 382 B 384 B ✓
image-HASH.js gzip 581 B 582 B ✓
index-HASH.js gzip 260 B 259 B ✓
link-HASH.js gzip 2.48 kB 2.48 kB ✓
routerDirect..HASH.js gzip 317 B 318 B ✓
script-HASH.js gzip 384 B 386 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.95 kB 7.95 kB ⚠️ +1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 128 kB 128 kB ✓
page.js gzip 287 kB 287 kB ✓
Total 415 kB 414 kB ✅ -941 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 619 B 615 B ✓
middleware-r..fest.js gzip 156 B 156 B ✓
middleware.js gzip 45.4 kB 45 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 47.1 kB 46.6 kB ✅ -442 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 718 B 718 B ✓
Total 718 B 718 B ✓
Build Cache
Canary PR Change
0.pack gzip 4.84 MB 4.84 MB ✓
index.pack gzip 119 kB 119 kB ✓
index.pack.old gzip 119 kB 119 kB ✓
Total 5.08 MB 5.08 MB ✅ -4.35 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 366 kB 366 kB ✓
app-page-exp..prod.js gzip 202 kB 202 kB ✓
app-page-tur...dev.js gzip 365 kB 365 kB ✓
app-page-tur..prod.js gzip 202 kB 202 kB ✓
app-page-tur...dev.js gzip 362 kB 362 kB ✓
app-page-tur..prod.js gzip 200 kB 200 kB ✓
app-page.run...dev.js gzip 362 kB 362 kB ✓
app-page.run..prod.js gzip 200 kB 200 kB ✓
app-route-ex...dev.js gzip 81.8 kB 81.8 kB ✓
app-route-ex..prod.js gzip 55.6 kB 55.6 kB ✓
app-route-tu...dev.js gzip 81.8 kB 81.8 kB ✓
app-route-tu..prod.js gzip 55.6 kB 55.6 kB ✓
app-route-tu...dev.js gzip 81.4 kB 81.4 kB ✓
app-route-tu..prod.js gzip 55.4 kB 55.4 kB ✓
app-route.ru...dev.js gzip 81.4 kB 81.4 kB ✓
app-route.ru..prod.js gzip 55.4 kB 55.4 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 45.4 kB 45.4 kB ✓
pages-api-tu..prod.js gzip 34.1 kB 34.1 kB ✓
pages-api.ru...dev.js gzip 45.4 kB 45.4 kB ✓
pages-api.ru..prod.js gzip 34.1 kB 34.1 kB ✓
pages-turbo....dev.js gzip 54.9 kB 54.9 kB ✓
pages-turbo...prod.js gzip 39.7 kB 39.7 kB ✓
pages.runtim...dev.js gzip 54.8 kB 54.8 kB ✓
pages.runtim..prod.js gzip 39.7 kB 39.7 kB ✓
server.runti..prod.js gzip 67.8 kB 67.8 kB ✓
use-cache-pr...dev.js gzip 71.6 kB 71.6 kB ✓
use-cache-pr...dev.js gzip 71.6 kB 71.6 kB ✓
use-cache-pr...dev.js gzip 69.9 kB 69.9 kB ✓
use-cache-pr...dev.js gzip 69.9 kB 69.9 kB ✓
Total 3.51 MB 3.51 MB ⚠️ +4 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/b8602c4f7ffaf267c5f4b0f8d98dcd5a9f338c11/next

Commit: b8602c4

@devjiwonchoi devjiwonchoi changed the title jiwon/gsp export diagnostics Improve generateStaticParams errors for static exports Jul 20, 2026
@devjiwonchoi devjiwonchoi mentioned this pull request Jul 20, 2026
Merged
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from 81b092b to aa6e944 Compare July 20, 2026 17:29
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from 461e27f to 0023c4b Compare July 20, 2026 17:29
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from aa6e944 to f3ce9fc Compare July 20, 2026 18:34
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from 0023c4b to 14f573a Compare July 20, 2026 18:34
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from f3ce9fc to c37b7ca Compare July 20, 2026 18:50
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from 14f573a to a55cdb9 Compare July 20, 2026 18:50
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from c37b7ca to 8e7a3d2 Compare July 20, 2026 19:00
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from a55cdb9 to 1bbc8c3 Compare July 20, 2026 19:00
@devjiwonchoi devjiwonchoi changed the title Improve generateStaticParams errors for static exports Throw for empty or incomplete generateStaticParams results with output: export Jul 20, 2026
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from 1bbc8c3 to a606de3 Compare July 20, 2026 19:36
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from 8e7a3d2 to d7b8eba Compare July 20, 2026 19:56
@devjiwonchoi devjiwonchoi changed the title Throw for empty or incomplete generateStaticParams results with output: export Throw for missing routes or params with output: export Jul 20, 2026
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from a606de3 to 37f2178 Compare July 20, 2026 20:09
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch 7 times, most recently from 8d5111b to f33917c Compare July 21, 2026 11:40
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from 37f2178 to db0dded Compare July 21, 2026 12:18
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from f33917c to 5e45407 Compare July 21, 2026 12:18
@devjiwonchoi
devjiwonchoi marked this pull request as ready for review July 21, 2026 15:11
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from 5e45407 to 5778adb Compare July 21, 2026 15:58
@devjiwonchoi devjiwonchoi changed the title Throw for missing routes or params with output: export Throw for empty or incomplete generateStaticParams results with output: export Jul 21, 2026
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from 5778adb to 8b7b58a Compare July 21, 2026 19:05
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from db0dded to 5800998 Compare July 21, 2026 19:05
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from 8b7b58a to da02d2d Compare July 21, 2026 19:17
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from 5800998 to c928555 Compare July 21, 2026 19:17
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from a294fb7 to e6245a9 Compare July 22, 2026 15:00
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch 2 times, most recently from 5b8fc88 to f9fd199 Compare July 23, 2026 18:09
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from f9fd199 to b848c8e Compare July 23, 2026 19:02
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-return-validation branch from a3fe59c to 0250d96 Compare July 23, 2026 19:02
@devjiwonchoi
devjiwonchoi force-pushed the jiwon/gsp-export-diagnostics branch from b848c8e to b8602c4 Compare July 23, 2026 20:27
@devjiwonchoi
devjiwonchoi merged commit f2e6abb into canary Jul 23, 2026
128 checks passed
@devjiwonchoi
devjiwonchoi deleted the jiwon/gsp-export-diagnostics branch July 23, 2026 21:26
devjiwonchoi added a commit that referenced this pull request Jul 23, 2026
@devjiwonchoi @icyJoseph
Throw when generateStaticParams returns invalid values (#95968)
8164354 
> [!TIP]
> This PR is best reviewed commit by commit.

### Why?

`generateStaticParams` must return an array of objects, but Next.js does
not currently provide a clear error when it returns something else.

### How?

- Throw when `generateStaticParams` does not return an array.
- Throw when an item in the returned array is not an object.
- Keep allowing `{}`. The follow-up rejects it with `output: 'export'`
when it leaves a dynamic route parameter missing.

Follow-up: #95969

Supersedes #95388.

<!-- NEXT_JS_LLM -->

Co-authored-by: SukkaW <isukkaw@gmail.com>

---------

Co-authored-by: Joseph <joseph.chamochumbi@vercel.com>
@devjiwonchoi devjiwonchoi mentioned this pull request Jul 23, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icyJoseph icyJoseph icyJoseph approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devjiwonchoi @icyJoseph