Turbopack: Simplify parent directory creation retry loop logic#95835
Merged
Conversation
Contributor
Stats from current PR🔴 1 regression
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: fd2acfc |
Contributor
Tests PassedCommit: fd2acfc |
![vercel[bot]](https://avatars.github.com/in/8329?s=60&v=4){kind=small}
bgw
force-pushed
the
bgw/simplify-parent-directory-creation
branch
from
July 15, 2026 21:38
5a0e4d9 to
8e50050
Compare
bgw
marked this pull request as ready for review
July 15, 2026 21:38
bgw
force-pushed
the
bgw/simplify-parent-directory-creation
branch
from
July 20, 2026 07:25
8e50050 to
fd2acfc
Compare
lukesandberg
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while reading through the symlink code.
The symlink logic had some clever
ErrorKind::AlreadyExistslogic that folded the retry into the main retry loop, but we still had a separate retry loop for after handlingErrorKind::NotFound. This folds the loops together.I hand-implemented the symlink version of this and had opus port it to the non-symlink version.