Fix Request Insights subscription initialization#95794
Merged
Merged
Conversation
Contributor
Stats from current PRWarning No stats were collected for Webpack because its stats job did not complete (it failed, was cancelled, or timed out). The results below only cover the bundlers that finished. ✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: 0ba6e91 |
Contributor
Tests PassedCommit: 0ba6e91 |
timneutkens
marked this pull request as ready for review
July 14, 2026 21:22
mischnic
approved these changes
Jul 15, 2026
mischnic
enabled auto-merge (squash)
July 15, 2026 10:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass the configured Request Insights state into the dev bundler service so it subscribes to insight updates during initialization. The service is constructed outside request-local tracing state, so checking only
isRequestInsightsEnabled()can incorrectly skip the subscription even when Request Insights is enabled in configuration.Verification
pnpm build-allpnpm prettier --with-node-modules --ignore-path .prettierignore --write packages/next/src/server/lib/dev-bundler-service.ts packages/next/src/server/lib/router-server.tsnpx eslint --config eslint.config.mjs --fix packages/next/src/server/lib/dev-bundler-service.ts packages/next/src/server/lib/router-server.ts