Turbopack: use module graph for NFT by mischnic · Pull Request #92901 · vercel/next.js

mischnic · 2026-04-16T15:43:50Z

skip traced edges properly in all graph traversals
iter_nodes and enumerate_nodes include the traced modules
- Don't propagate is_self_async inside of traced references as a perf optimization
fix performance
validate that NFT JSON files are identical
~~validate/adjust bundle analyzer output~~ will be in followup
audit fn chunking_type() changes

Benchmark:

* ced85b3108 - (2 weeks ago) refactor - Niklas Mischkulnig (HEAD -> mischnic/nft-module-graph, origin/mischnic/nft-module-graph)

TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build   334.96s user 44.57s system 788% cpu 48.152 total
TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build   343.39s user 42.61s system 809% cpu 47.659 total

* 5edf48238f - (77 minutes ago) v16.3.0-canary.32 - next-js-bot[bot] (HEAD, tag: v16.3.0-canary.32)

TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build   333.42s user 43.57s system 712% cpu 52.877 total
TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build   332.95s user 43.15s system 791% cpu 47.515 total
TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build   337.59s user 41.28s system 771% cpu 49.117 total
TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build   335.25s user 45.53s system 718% cpu 52.975 total

Previous benchmarks

52212418699f362904d64c08e544d4994e8d27fa mischnic/nft-module-graph

pnpm next build   371.41s user 66.39s system 737% cpu 59.353 total
pnpm next build   380.13s user 59.62s system 751% cpu 58.548 total
pnpm next build   374.25s user 60.55s system 761% cpu 57.102 total

8e4cfc5062 canary

pnpm next build   370.77s user 53.89s system 762% cpu 55.725 total
pnpm next build   383.16s user 55.61s system 744% cpu 58.921 total
pnpm next build   382.34s user 53.51s system 757% cpu 57.512 total
pnpm next build   381.15s user 54.50s system 751% cpu 57.943 total

b0d5411a79 mischnic/nft-module-graph
pnpm next build --experimental-build-mode=compil  368.75s user 62.05s system 749% cpu 57.445 total
pnpm next build --experimental-build-mode=compil  368.95s user 58.42s system 763% cpu 56.004 total

0e3ad2768bd3b036e96f66e4b770a16bb0b38705 mischnic/nft-module-graph
pnpm next build --experimental-build-mode=compil  369.48s user 60.62s system 748% cpu 57.494 total
pnpm next build --experimental-build-mode=compil  374.89s user 52.27s system 730% cpu 58.449 total
pnpm next build --experimental-build-mode=compil  375.02s user 52.89s system 747% cpu 57.274 total

f37073e1d96f6d846cd333b93fccd1dd7bdc253e mischnic/speed-next-dynamic-map
pnpm next build --experimental-build-mode=compil  389.58s user 55.98s system 704% cpu 1:03.21 total

e599b11e2d6b09a92600cfca6d9b338ed1f7537d mischnic/fix-side-effect-edge-removal
pnpm next build --experimental-build-mode=compil  386.60s user 53.34s system 720% cpu 1:01.09 total

f68f70b0446cc698f0206acefefb51946c1c1545 canary
pnpm next build --experimental-build-mode=compil  387.46s user 53.72s system 738% cpu 59.716 total
pnpm next build --experimental-build-mode=compil  390.33s user 53.54s system 734% cpu 1:00.43 total
pnpm next build --experimental-build-mode=compil  385.33s user 56.55s system 722% cpu 1:01.18 total
pnpm next build --experimental-build-mode=compil  386.49s user 56.44s system 726% cpu 1:00.96 total

b1ed4553e6 origin/mischnic/nft-module-graph
pnpm next build --experimental-build-mode=compile  467.28s user 75.24s system 791% cpu 1:08.56 total
pnpm next build --experimental-build-mode=compile  465.00s user 76.80s system 831% cpu 1:05.20 total
pnpm next build --experimental-build-mode=compile  473.86s user 70.73s system 790% cpu 1:08.90 total

3cb77c844b canary
pnpm next build --experimental-build-mode=compile  367.91s user 58.06s system 726% cpu 58.672 total
pnpm next build --experimental-build-mode=compile  362.97s user 57.68s system 746% cpu 56.379 total
pnpm next build --experimental-build-mode=compile  364.59s user 57.01s system 724% cpu 58.167 total

mischnic · 2026-04-16T15:44:04Z

Turbopack: show codeframe when tracing too much #94207
Turbopack: fix bundle-analyzer for NFT change #93363
Turbopack: use module graph for NFT #92901 👈 (View in Graphite)
Turbopack: remove unused module references #93335 : 1 other dependent PR (#93349 )
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-27T08:27:10Z

Stats skipped

Commit: a85b4f7
View workflow run

github-actions · 2026-04-27T08:28:30Z

Tests Passed

Commit: ced85b3

mischnic · 2026-05-28T18:10:05Z

Merge activity

May 28, 6:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
May 28, 6:10 PM UTC: @mischnic merged this pull request with Graphite.

#95815 refactored the NFT flow and ended up only tracing the RSC template and it's subgraph. Not the server actions loader module whose module graph is completely separate. --- Clauded. Attempts to fix #95130 (reply in thread). --- <details> ## Summary Fixes the NFT tracing regression behind #95815 and the deploy failures reported in #87737 (comment). Since the 16.3 NFT rewrite (#94224 / #92901), a `serverExternalPackages` entry that is imported **only from a `'use server'` action referenced by a client component** ends up in the route's trace as the content-hashed alias symlink (`.next/node_modules/<pkg>-<hash>`) **without the store files the symlink points to**. Any output assembled from the traces (Vercel lambdas, `output: 'standalone'`) then contains a dangling symlink, and invoking the action throws `Failed to load external module <pkg>-<hash>` (HTTP 500). 16.2.9 traces both. Both CJS and ESM externals are affected, with any package manager — the ESM/bun/monorepo framing in the issue reports was a coincidence of which packages were only reachable through actions. The cause: `AppEndpoint::trace_result` started the trace DFS only from `rsc_entry`, but the server actions loader is a separate module-graph entry (`additional_entries`). It is chunked into the endpoint output (which emits the alias symlink via the chunk's output assets), yet its subgraph — including the externals' traced target files — was never visited by the tracer. `trace_endpoint` now accepts multiple entry modules and the app endpoint passes the actions loader alongside `rsc_entry`. The test observes the user-visible failure: it builds with `output: 'standalone'`, deletes everything except the standalone output (so only traced files are available, like a deployed lambda), runs `server.js`, and invokes the server action in a browser. Without the fix the action fails with `Failed to load external module lodash-<hash>`; on 16.2.9 the same fixture responds with the action result. Note the fixture must not import the externals from any other route: the standalone output is the union of all route traces, so a route that traces them correctly would mask the missing entries. ## Verification - `pnpm test-start-turbo test/production/standalone-mode/server-action-externals/standalone-mode-server-action-externals.test.ts` — fails without the fix (`Failed to load external module lodash-fb78ad0536ffcdab` from the standalone server), passes with it. The equivalent standalone flow on `next@16.2.9` returns the action result with HTTP 200. - `pnpm test-start-turbo test/e2e/externals-transitive/externals-transitive.test.ts` - `pnpm test-start-turbo test/production/standalone-mode/server-actions/standalone-mode-server-actions.test.ts`  </details>

- [x] skip traced edges properly in all graph traversals - [x] iter_nodes and enumerate_nodes include the traced modules - [x] Don't propagate is_self_async inside of traced references as a perf optimization - [x] fix performance - [x] validate that NFT JSON files are identical - [x] ~~validate/adjust bundle analyzer output~~ will be in followup - [x] audit `fn chunking_type()` changes Benchmark: ``` * ced85b3 - (2 weeks ago) refactor - Niklas Mischkulnig (HEAD -> mischnic/nft-module-graph, origin/mischnic/nft-module-graph) TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build 334.96s user 44.57s system 788% cpu 48.152 total TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build 343.39s user 42.61s system 809% cpu 47.659 total * 5edf482 - (77 minutes ago) v16.3.0-canary.32 - next-js-bot[bot] (HEAD, tag: v16.3.0-canary.32) TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build 333.42s user 43.57s system 712% cpu 52.877 total TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build 332.95s user 43.15s system 791% cpu 47.515 total TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build 337.59s user 41.28s system 771% cpu 49.117 total TURBOPACK_PERSISTENT_CACHE=0 NEXT_TURBOPACK_TRACING= pnpm next build 335.25s user 45.53s system 718% cpu 52.975 total ``` <details> <summary>Previous benchmarks</summary> ``` 52212418699f362904d64c08e544d4994e8d27fa mischnic/nft-module-graph pnpm next build 371.41s user 66.39s system 737% cpu 59.353 total pnpm next build 380.13s user 59.62s system 751% cpu 58.548 total pnpm next build 374.25s user 60.55s system 761% cpu 57.102 total 8e4cfc5 canary pnpm next build 370.77s user 53.89s system 762% cpu 55.725 total pnpm next build 383.16s user 55.61s system 744% cpu 58.921 total pnpm next build 382.34s user 53.51s system 757% cpu 57.512 total pnpm next build 381.15s user 54.50s system 751% cpu 57.943 total ``` ``` b0d5411a79 mischnic/nft-module-graph pnpm next build --experimental-build-mode=compil 368.75s user 62.05s system 749% cpu 57.445 total pnpm next build --experimental-build-mode=compil 368.95s user 58.42s system 763% cpu 56.004 total 0e3ad27 mischnic/nft-module-graph pnpm next build --experimental-build-mode=compil 369.48s user 60.62s system 748% cpu 57.494 total pnpm next build --experimental-build-mode=compil 374.89s user 52.27s system 730% cpu 58.449 total pnpm next build --experimental-build-mode=compil 375.02s user 52.89s system 747% cpu 57.274 total f37073e mischnic/speed-next-dynamic-map pnpm next build --experimental-build-mode=compil 389.58s user 55.98s system 704% cpu 1:03.21 total e599b11e2d6b09a92600cfca6d9b338ed1f7537d mischnic/fix-side-effect-edge-removal pnpm next build --experimental-build-mode=compil 386.60s user 53.34s system 720% cpu 1:01.09 total f68f70b canary pnpm next build --experimental-build-mode=compil 387.46s user 53.72s system 738% cpu 59.716 total pnpm next build --experimental-build-mode=compil 390.33s user 53.54s system 734% cpu 1:00.43 total pnpm next build --experimental-build-mode=compil 385.33s user 56.55s system 722% cpu 1:01.18 total pnpm next build --experimental-build-mode=compil 386.49s user 56.44s system 726% cpu 1:00.96 total ``` ``` b1ed455 origin/mischnic/nft-module-graph pnpm next build --experimental-build-mode=compile 467.28s user 75.24s system 791% cpu 1:08.56 total pnpm next build --experimental-build-mode=compile 465.00s user 76.80s system 831% cpu 1:05.20 total pnpm next build --experimental-build-mode=compile 473.86s user 70.73s system 790% cpu 1:08.90 total 3cb77c8 canary pnpm next build --experimental-build-mode=compile 367.91s user 58.06s system 726% cpu 58.672 total pnpm next build --experimental-build-mode=compile 362.97s user 57.68s system 746% cpu 56.379 total pnpm next build --experimental-build-mode=compile 364.59s user 57.01s system 724% cpu 58.167 total ``` </details>

) vercel#95815 refactored the NFT flow and ended up only tracing the RSC template and it's subgraph. Not the server actions loader module whose module graph is completely separate. --- Clauded. Attempts to fix vercel#95130 (reply in thread). --- <details> ## Summary Fixes the NFT tracing regression behind vercel#95815 and the deploy failures reported in vercel#87737 (comment). Since the 16.3 NFT rewrite (vercel#94224 / vercel#92901), a `serverExternalPackages` entry that is imported **only from a `'use server'` action referenced by a client component** ends up in the route's trace as the content-hashed alias symlink (`.next/node_modules/<pkg>-<hash>`) **without the store files the symlink points to**. Any output assembled from the traces (Vercel lambdas, `output: 'standalone'`) then contains a dangling symlink, and invoking the action throws `Failed to load external module <pkg>-<hash>` (HTTP 500). 16.2.9 traces both. Both CJS and ESM externals are affected, with any package manager — the ESM/bun/monorepo framing in the issue reports was a coincidence of which packages were only reachable through actions. The cause: `AppEndpoint::trace_result` started the trace DFS only from `rsc_entry`, but the server actions loader is a separate module-graph entry (`additional_entries`). It is chunked into the endpoint output (which emits the alias symlink via the chunk's output assets), yet its subgraph — including the externals' traced target files — was never visited by the tracer. `trace_endpoint` now accepts multiple entry modules and the app endpoint passes the actions loader alongside `rsc_entry`. The test observes the user-visible failure: it builds with `output: 'standalone'`, deletes everything except the standalone output (so only traced files are available, like a deployed lambda), runs `server.js`, and invokes the server action in a browser. Without the fix the action fails with `Failed to load external module lodash-<hash>`; on 16.2.9 the same fixture responds with the action result. Note the fixture must not import the externals from any other route: the standalone output is the union of all route traces, so a route that traces them correctly would mask the missing entries. ## Verification - `pnpm test-start-turbo test/production/standalone-mode/server-action-externals/standalone-mode-server-action-externals.test.ts` — fails without the fix (`Failed to load external module lodash-fb78ad0536ffcdab` from the standalone server), passes with it. The equivalent standalone flow on `next@16.2.9` returns the action result with HTTP 200. - `pnpm test-start-turbo test/e2e/externals-transitive/externals-transitive.test.ts` - `pnpm test-start-turbo test/production/standalone-mode/server-actions/standalone-mode-server-actions.test.ts`  </details>

nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Apr 16, 2026

mischnic force-pushed the mischnic/nft-module-graph branch 3 times, most recently from 467a71d to affcef5 Compare April 20, 2026 14:09

mischnic force-pushed the mischnic/nft-module-graph branch 5 times, most recently from a211af5 to 3c9e89d Compare April 27, 2026 07:54

github-actions Bot added the tests label Apr 27, 2026

mischnic changed the base branch from canary to graphite-base/92901 April 27, 2026 13:17

mischnic force-pushed the mischnic/nft-module-graph branch from 3c9e89d to 875593b Compare April 27, 2026 13:17

mischnic changed the base branch from graphite-base/92901 to mischnic/fix-side-effect-edge-removal April 27, 2026 13:17

This was referenced Apr 27, 2026

Turbopack: only compute module ids for included modules #93276

Merged

Turbopack: cheaper check in map_next_dynamic #93283

Merged

vercel deleted a comment from nextjs-bot Apr 27, 2026

vercel deleted a comment from codspeed-hq Bot Apr 27, 2026

mischnic force-pushed the mischnic/fix-side-effect-edge-removal branch from 9f6dd11 to d83638e Compare April 28, 2026 11:02

mischnic force-pushed the mischnic/nft-module-graph branch from c287212 to 05f5347 Compare April 28, 2026 11:02

mischnic changed the base branch from mischnic/fix-side-effect-edge-removal to graphite-base/92901 April 28, 2026 12:11

mischnic force-pushed the mischnic/nft-module-graph branch from 05f5347 to 08de2b2 Compare April 28, 2026 12:11

mischnic changed the base branch from graphite-base/92901 to mischnic/iter_reachable_nodes April 28, 2026 12:11

mischnic mentioned this pull request Apr 28, 2026

Turbopack: iter_reachable_modules #93315

Merged

mischnic requested a review from a team April 28, 2026 13:15

mischnic marked this pull request as ready for review April 28, 2026 13:26

mischnic mentioned this pull request Apr 29, 2026

Turbopack: remove ModuleResolveResultItem::OutputAsset #93349

Merged

mischnic changed the base branch from mischnic/remove-unused-references to graphite-base/92901 April 29, 2026 10:43

mischnic force-pushed the graphite-base/92901 branch from e13b7ae to 5eec78a Compare April 29, 2026 10:43

mischnic force-pushed the mischnic/nft-module-graph branch from 5221241 to adfd39a Compare April 29, 2026 12:58

mischnic changed the base branch from graphite-base/92901 to canary April 29, 2026 12:58

mischnic force-pushed the mischnic/nft-module-graph branch 2 times, most recently from bd05675 to 8eddf37 Compare April 29, 2026 13:24

mischnic mentioned this pull request Apr 29, 2026

Turbopack: fix bundle-analyzer for NFT change #93363

Merged

lukesandberg reviewed May 6, 2026

View reviewed changes

Comment thread turbopack/crates/turbopack-ecmascript/src/references/external_module.rs Outdated

lukesandberg reviewed May 6, 2026

View reviewed changes

Comment thread crates/next-api/src/nft_json.rs

lukesandberg reviewed May 7, 2026

View reviewed changes

Comment thread crates/next-api/src/nft_json.rs

lukesandberg approved these changes May 7, 2026

View reviewed changes

mischnic force-pushed the mischnic/nft-module-graph branch 2 times, most recently from 5ebe664 to fb3e6e5 Compare May 13, 2026 15:48

lukesandberg approved these changes May 13, 2026

View reviewed changes

mischnic force-pushed the mischnic/nft-module-graph branch from 62b6a8b to a85b4f7 Compare May 28, 2026 09:57

mischnic added 4 commits May 28, 2026 14:46

Turbopack: use module graph for NFT

62c14c4

dedupe

4ce228c

TracedMode

b071fa5

refactor

ced85b3

mischnic force-pushed the mischnic/nft-module-graph branch from a85b4f7 to ced85b3 Compare May 28, 2026 12:47

mischnic merged commit 5ee7005 into canary May 28, 2026
294 of 298 checks passed

mischnic deleted the mischnic/nft-module-graph branch May 28, 2026 18:10

mischnic mentioned this pull request May 28, 2026

Turbopack: show codeframe when tracing too much #94207

Merged

gaearon mentioned this pull request Jul 15, 2026

Turbopack: trace externals imported only by server actions #95824

Merged

joshuatownsend mentioned this pull request Aug 9, 2026

Standalone build: residual "whole project traced" Turbopack warning inflates dist/minder-server size joshuatownsend/project-minder#284

Open

Navigation Menu

Uh oh!

Turbopack: use module graph for NFT - #92901

Turbopack: use module graph for NFT#92901
mischnic merged 4 commits into
canaryfrom
mischnic/nft-module-graph

mischnic commented Apr 16, 2026 •

edited

Loading

Uh oh!

mischnic commented Apr 16, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mischnic commented May 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mischnic commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mischnic commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats skipped

Uh oh!

github-actions Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests Passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mischnic commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mischnic commented Apr 16, 2026 •

edited

Loading

mischnic commented Apr 16, 2026 •

edited

Loading

github-actions Bot commented Apr 27, 2026 •

edited

Loading

github-actions Bot commented Apr 27, 2026 •

edited

Loading

mischnic commented May 28, 2026 •

edited

Loading