Skip to content

Use correct default for query - #5851

Merged
timneutkens merged 2 commits into
vercel:canaryfrom
timneutkens:fix/router-error
Dec 10, 2018
Merged

timneutkens merged 2 commits into
vercel:canaryfrom
timneutkens:fix/router-error

Conversation

@timneutkens

@timneutkens timneutkens commented Dec 10, 2018

Copy link
Copy Markdown
Contributor

Fixes #2943
Fixes #4341

The backwards-compatible version of this fix. It's basically the same as with router.js, where we always know the query will be at least {}

@timneutkens
timneutkens requested a review from leo December 10, 2018 21:26
@timneutkens
timneutkens merged commit 93424b6 into vercel:canary Dec 10, 2018
@timneutkens
timneutkens deleted the fix/router-error branch December 10, 2018 22:40
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shallowEquals throws when using custom server and not passing an object for query to app.render

2 participants