Ask Cmdr: review and apply natural-language bulk renames - #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds natural-language bulk rename to Ask Cmdr with an explicit, reviewable proposal workflow. The agent can inspect the focused pane and propose filename changes, but cannot approve or apply them. Only a frontend user action can send approved rows through the existing operation engine.
This also improves OpenAI-compatible provider setup so the feature works with Qwen/DashScope and custom endpoints, and addresses the pane-context, streaming, copyability, and activity-state issues discovered during end-to-end QA.
Why this shape
Renaming is a destructive-looking action even when it stays within one folder, so the design keeps authority at a hard boundary:
Access::Readtools for context and oneAccess::Proposetool for staging a plan.Access::Proposecannot mutate the filesystem.This keeps the useful natural-language workflow while preserving Cmdr's core data-safety invariant.
Natural-language bulk rename
Access::ProposeMCP tool,propose_rename_plan.EXPECTED_PROPOSE_TOOL_NAMESwhile keeping all structural no-write assertions intact.list_pane_files, an agent-only read tool backed by the focused pane's existing listing cache.Agent context and reliability
AI provider setup
Internationalization and documentation
Validation
git diff --checkis clean.Remaining advisory warning
The checker reports file-length growth in two existing integration hubs:
apps/desktop/src-tauri/src/commands/agent.rsapps/desktop/src/routes/(main)/+page.svelteThe feature-specific business logic remains in the colocated agent tool, proposal, review-dialog, and bulk-rename modules.