Skip to content

adds RPOPCount and LPOPCount to transaction - #874

Merged
shohamazon merged 1 commit into
valkey-io:mainfrom
shohamazon:list_commands_transaction
Feb 1, 2024
Merged

shohamazon merged 1 commit into
valkey-io:mainfrom
shohamazon:list_commands_transaction

Conversation

@shohamazon

Copy link
Copy Markdown
Collaborator

No description provided.

@shohamazon
shohamazon requested a review from a team as a code owner January 29, 2024 16:16
@Yury-Fridlyand Yury-Fridlyand added the node 🐢 Node.js wrapper label Jan 30, 2024
@shachlanAmazon

Copy link
Copy Markdown
Contributor

please add to tests

@shohamazon shohamazon added the python 🐍 Python wrapper label Jan 31, 2024
@shohamazon
shohamazon force-pushed the list_commands_transaction branch 2 times, most recently from 000d6ae to c587142 Compare February 1, 2024 13:49
@shohamazon

Copy link
Copy Markdown
Collaborator Author

please add to tests

Done

Comment thread node/src/BaseClient.ts
* If `key` holds a value that is not a list, an error is raised.
*/
public lpop(
key: string,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please either remove stylistic changes, or update the eslint rules to enforce this.
On my machine this is changed to a single line 🤷

Comment thread node/tests/TestUtilities.ts
@shohamazon
shohamazon force-pushed the list_commands_transaction branch 3 times, most recently from 45984e4 to d4782c4 Compare February 1, 2024 16:06
@shohamazon
shohamazon force-pushed the list_commands_transaction branch from d4782c4 to 31b93be Compare February 1, 2024 16:08
@shohamazon
shohamazon merged commit 10ffd68 into valkey-io:main Feb 1, 2024
@shohamazon
shohamazon deleted the list_commands_transaction branch February 1, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

node 🐢 Node.js wrapper python 🐍 Python wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants