connection timeout value fix for clients - #4966
Merged
Merged
Conversation
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 19:13 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 19:13 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 19:13 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 19:13 — with
GitHub Actions
Error
xShinnRyuu
force-pushed
the
connection-timeout-test
branch
from
November 12, 2025 19:23
193ce51 to
4f2c7f6
Compare
Signed-off-by: Thomas Zhou <thomas.zhou@improving.com>
xShinnRyuu
force-pushed
the
connection-timeout-test
branch
from
November 12, 2025 19:24
4f2c7f6 to
009044f
Compare
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 19:24 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 19:24 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 19:24 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 19:24 — with
GitHub Actions
Error
Signed-off-by: Thomas Zhou <thomas.zhou@improving.com>
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 20:40 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 20:40 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 20:40 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 20:40 — with
GitHub Actions
Error
Signed-off-by: Thomas Zhou <thomas.zhou@improving.com>
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 21:37 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 21:37 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 21:37 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 21:37 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:01 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:01 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:01 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:01 — with
GitHub Actions
Error
xShinnRyuu
force-pushed
the
connection-timeout-test
branch
from
November 12, 2025 22:10
e84da47 to
10946c4
Compare
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:10 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:10 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:10 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:10 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:30 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:30 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:30 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 22:30 — with
GitHub Actions
Error
xShinnRyuu
marked this pull request as ready for review
November 12, 2025 22:40
Signed-off-by: Thomas Zhou <thomas.zhou@improving.com>
xShinnRyuu
force-pushed
the
connection-timeout-test
branch
from
November 12, 2025 23:05
50613d8 to
2698527
Compare
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 23:05 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 23:05 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 23:05 — with
GitHub Actions
Error
xShinnRyuu
had a problem deploying
to
AWS_ACTIONS
November 12, 2025 23:06 — with
GitHub Actions
Error
alexr-bq
approved these changes
Nov 12, 2025
yipin-chen
approved these changes
Nov 12, 2025
yipin-chen
left a comment
Collaborator
There was a problem hiding this comment.
Approve. You can merge once CIs are green.
Signed-off-by: Thomas Zhou <thomas.zhou@improving.com>
xShinnRyuu
requested a deployment
to
AWS_ACTIONS
November 12, 2025 23:42 — with
GitHub Actions
Waiting
xShinnRyuu
requested a deployment
to
AWS_ACTIONS
November 12, 2025 23:42 — with
GitHub Actions
Waiting
xShinnRyuu
requested a deployment
to
AWS_ACTIONS
November 12, 2025 23:42 — with
GitHub Actions
Waiting
xShinnRyuu
requested a deployment
to
AWS_ACTIONS
November 12, 2025 23:43 — with
GitHub Actions
Waiting
This was referenced Nov 13, 2025
Copilot AI
pushed a commit
to synchronoss/valkey-glide
that referenced
this pull request
Dec 4, 2025
* connection timeout value fix for clients Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Add in logging for connection timing Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Fix lint errors Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Add changelog and remove redundant imports Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Fix Go client timeout tests Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> --------- Signed-off-by: Thomas Zhou <thomas.zhou@improving.com>
netofontes
pushed a commit
to synchronoss/valkey-glide
that referenced
this pull request
Dec 4, 2025
* connection timeout value fix for clients Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Add in logging for connection timing Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Fix lint errors Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Add changelog and remove redundant imports Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Fix Go client timeout tests Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> --------- Signed-off-by: Thomas Zhou <thomas.zhou@improving.com>
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
* connection timeout value fix for clients Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Add in logging for connection timing Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Fix lint errors Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Add changelog and remove redundant imports Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> * Fix Go client timeout tests Signed-off-by: Thomas Zhou <thomas.zhou@improving.com> --------- Signed-off-by: Thomas Zhou <thomas.zhou@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
connectionTimeoutvalue from250msto2000ms, aligning it with the documented value.Request timeoutandConnection timeoutvalues, even when they are not explicitly overridden during client creation.Testing
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: