Skip to content

Core: Fix UDS infinite loop - #4612

Merged
jamesx-improving merged 4 commits into
mainfrom
core/jamesx-fix-uds-inf-loop
Aug 22, 2025
Merged

Core: Fix UDS infinite loop#4612
jamesx-improving merged 4 commits into
mainfrom
core/jamesx-fix-uds-inf-loop

Conversation

@jamesx-improving

@jamesx-improving jamesx-improving commented Aug 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue link

This Pull Request is linked to issue (URL): #4591

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@jamesx-improving
jamesx-improving requested a review from a team as a code owner August 16, 2025 01:01
@avifenesh

avifenesh commented Aug 16, 2025

Copy link
Copy Markdown
Member

LGTM please run full matrix on this branch

Yury-Fridlyand
Yury-Fridlyand approved these changes Aug 17, 2025
View reviewed changes

@Yury-Fridlyand Yury-Fridlyand left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this?

@jamesx-improving

jamesx-improving commented Aug 18, 2025

Copy link
Copy Markdown
Collaborator Author

LGTM please run full matrix on this branch

Full Matrix Test initiated on this branch
https://github.com/valkey-io/valkey-glide/actions/runs/17048156054

yipin-chen
yipin-chen approved these changes Aug 19, 2025
View reviewed changes

@yipin-chen yipin-chen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGELOG

@jamesx-improving
Core: Fix UDS infinite loop
3b060a4 
Signed-off-by: James Xin <james.xin@improving.com>
@jamesx-improving
CHANGELOG
d326e62 
Signed-off-by: James Xin <james.xin@improving.com>
@jamesx-improving
jamesx-improving force-pushed the core/jamesx-fix-uds-inf-loop branch from afdc5a8 to d326e62 Compare August 20, 2025 22:55
@jamesx-improving

jamesx-improving commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator Author

LGTM please run full matrix on this branch

Full Matrix Test initiated on this branch https://github.com/valkey-io/valkey-glide/actions/runs/17048156054

All failures in the Full Matrix Test on this branch is either well-known flaky tests, or network errors.

@jamesx-improving
jamesx-improving merged commit a4d38b1 into main Aug 22, 2025
61 of 65 checks passed
@jamesx-improving
jamesx-improving deleted the core/jamesx-fix-uds-inf-loop branch August 22, 2025 01:50
alexr-bq pushed a commit that referenced this pull request Sep 3, 2025
@jamesx-improving @alexr-bq
Core: Fix UDS infinite loop (#4612)
5b4fde2 
* Core: Fix UDS infinite loop

Signed-off-by: James Xin <james.xin@improving.com>

* CHANGELOG

Signed-off-by: James Xin <james.xin@improving.com>

---------

Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
xShinnRyuu pushed a commit that referenced this pull request Sep 24, 2025
@jamesx-improving @xShinnRyuu
Core: Fix UDS infinite loop (#4612)
9b7f35d 
* Core: Fix UDS infinite loop

Signed-off-by: James Xin <james.xin@improving.com>

* CHANGELOG

Signed-off-by: James Xin <james.xin@improving.com>

---------

Signed-off-by: James Xin <james.xin@improving.com>
@jeremyprime jeremyprime mentioned this pull request Aug 19, 2026
Closed
affonsov pushed a commit that referenced this pull request Aug 21, 2026
@jamesx-improving
Core: Fix UDS infinite loop (#4612)
689f118 
* Core: Fix UDS infinite loop

Signed-off-by: James Xin <james.xin@improving.com>

* CHANGELOG

Signed-off-by: James Xin <james.xin@improving.com>

---------

Signed-off-by: James Xin <james.xin@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avifenesh avifenesh avifenesh approved these changes
@yipin-chen yipin-chen yipin-chen approved these changes
+1 more reviewer
@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesx-improving @avifenesh @Yury-Fridlyand @yipin-chen