Go: XInfoStream update response by prateek-kumar-improving · Pull Request #4136 · valkey-io/valkey-glide

prateek-kumar-improving · 2025-06-10T00:37:09Z

Issue link

This Pull Request is linked to issue (URL): #4144

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

marcind · 2025-06-12T16:18:32Z

 //
 // [valkey.io]: https://valkey.io/commands/xinfo-stream/
-func (client *baseClient) XInfoStream(ctx context.Context, key string) (map[string]any, error) {
+func (client *baseClient) XInfoStream(ctx context.Context, key string) (models.XInfoStreamResponse, error) {


@Yury-Fridlyand how do these sort of response type changes affect the batch API?

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

jbrinkman

Approved pending changes discussed.

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving · 2025-06-12T20:32:18Z

Approved pending changes discussed.

Updated. KeyValue struct added:

type KeyValue struct {
	// The name of the field
	Key string
	// The value of the field
	Value string
}

prateek-kumar-improving added 2 commits June 9, 2025 17:36

Go: Add XInfoStream command response

c547732

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

Merge branch 'release-2.0' into go/xinfo-stream-update-command

d256954

Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 10, 2025 00:38 — with GitHub Actions Error

prateek-kumar-improving changed the title ~~Go: Add XInfoStream command response~~ Go: XInfoStream update response Jun 10, 2025

yipin-chen added the go 🏃 golang wrapper label Jun 10, 2025

Merge branch 'release-2.0' into go/xinfo-stream-update-command

d20fcaf

Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 10, 2025 19:09 — with GitHub Actions Error

Go: Update examples

6449b7d

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 10, 2025 19:34 — with GitHub Actions Error

Go: Update examples

d861537

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 10, 2025 19:58 — with GitHub Actions Error

prateek-kumar-improving requested a review from jbrinkman June 10, 2025 19:59

prateek-kumar-improving mentioned this pull request Jun 10, 2025

Go: Return smart object for some commands #4144

Closed

7 tasks

prateek-kumar-improving requested a review from yipin-chen June 10, 2025 20:04

Go: Update examples

38a3bd9

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 10, 2025 20:23 — with GitHub Actions Error

Go: Update examples

f912e11

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 10, 2025 21:10 — with GitHub Actions Error

Merge branch 'release-2.0' into go/xinfo-stream-update-command

cc28138

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 10, 2025 21:12 — with GitHub Actions Error

prateek-kumar-improving marked this pull request as ready for review June 10, 2025 21:23

prateek-kumar-improving requested a review from a team as a code owner June 10, 2025 21:23

Go: Add XInfoStream command response

8057ccd

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 10, 2025 21:27 — with GitHub Actions Error

marcind reviewed Jun 11, 2025

View reviewed changes

Comment thread go/response_handlers.go Outdated

tjzhang-BQ reviewed Jun 11, 2025

View reviewed changes

Comment thread go/stream_commands_test.go Outdated

Yury-Fridlyand reviewed Jun 11, 2025

View reviewed changes

Comment thread go/response_handlers.go Outdated

Comment thread go/stream_commands_test.go Outdated

Comment thread go/stream_commands_test.go Outdated

Merge branch 'release-2.0' into go/xinfo-stream-update-command

9db8211

Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 11, 2025 06:11 — with GitHub Actions Error

Go: Fix review comments

2dee168

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 15:40 — with GitHub Actions Error

Go: Fix review comments

50b5306

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 15:43 — with GitHub Actions Error

Merge branch 'release-2.0' into go/xinfo-stream-update-command

c8bdd06

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 15:44 — with GitHub Actions Error

marcind reviewed Jun 12, 2025

View reviewed changes

Yury-Fridlyand approved these changes Jun 12, 2025

View reviewed changes

Comment thread go/integTest/shared_commands_test.go Outdated

Comment thread go/integTest/shared_commands_test.go Outdated

Go: Fix review comments

7d54c0c

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 17:54 — with GitHub Actions Error

Go: Fix review comments

0acd328

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 18:18 — with GitHub Actions Error

Go: Fix review comments

1f8ecdb

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 18:33 — with GitHub Actions Error

jbrinkman reviewed Jun 12, 2025

View reviewed changes

Comment thread go/models/stream_command_results.go Outdated

Comment thread go/models/stream_command_results.go Outdated

Go: Fix review comments

44d830a

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 18:48 — with GitHub Actions Error

Go: Fix review comments

1e96e8d

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 19:05 — with GitHub Actions Error

Go: Fix review comments

c45efcf

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 19:20 — with GitHub Actions Error

Go: Fix review comments

2244434

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 19:35 — with GitHub Actions Error

Merge branch 'release-2.0' into go/xinfo-stream-update-command

c69de93

prateek-kumar-improving had a problem deploying to AWS_ACTIONS June 12, 2025 19:53 — with GitHub Actions Error

jbrinkman approved these changes Jun 12, 2025

View reviewed changes

Go: Fix review comments

a1e813a

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>

prateek-kumar-improving requested a deployment to AWS_ACTIONS June 12, 2025 20:30 — with GitHub Actions Waiting

prateek-kumar-improving merged commit 4294fbb into release-2.0 Jun 12, 2025

yipin-chen deleted the go/xinfo-stream-update-command branch June 12, 2025 20:50

Navigation Menu

Uh oh!

Go: XInfoStream update response - #4136

Go: XInfoStream update response#4136
prateek-kumar-improving merged 36 commits into
release-2.0from
go/xinfo-stream-update-command

prateek-kumar-improving commented Jun 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcind Jun 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbrinkman left a comment

Uh oh!

prateek-kumar-improving commented Jun 12, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

prateek-kumar-improving commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue link

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcind Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbrinkman left a comment

Choose a reason for hiding this comment

Uh oh!

prateek-kumar-improving commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

prateek-kumar-improving commented Jun 10, 2025 •

edited

Loading

prateek-kumar-improving commented Jun 12, 2025 •

edited

Loading