Skip to content

Go: Fix Ordering of Sorted Set With Scores Commands - #3712

Merged
edlng merged 5 commits into
valkey-io:mainfrom
Bit-Quill:go/edlng-fix-zcommand-orders
Apr 30, 2025
Merged

edlng merged 5 commits into
valkey-io:mainfrom
Bit-Quill:go/edlng-fix-zcommand-orders

Conversation

@edlng

@edlng edlng commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

This PR fixes the ordering of the result returned in other sorted set commands. A follow-up to #3694 for applying the fix to all other relevant commands.

Issue link

This Pull Request is linked to issue (URL): #3639

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Edward Liang <edward.liang@improving.com>
@edlng edlng added the go 🏃 golang wrapper label Apr 29, 2025
@edlng
edlng requested a review from a team as a code owner April 29, 2025 23:09
Signed-off-by: Edward Liang <edward.liang@improving.com>
Comment thread CHANGELOG.md Outdated
edlng and others added 2 commits April 30, 2025 09:05
@edlng
edlng merged commit 44963fd into valkey-io:main Apr 30, 2025
@edlng
edlng deleted the go/edlng-fix-zcommand-orders branch April 30, 2025 17:40
@avifenesh avifenesh added this to the 1.3.3 milestone Apr 30, 2025
@avifenesh avifenesh removed this from Valkey 8.0 Apr 30, 2025
@avifenesh avifenesh mentioned this pull request Apr 30, 2025
avifenesh pushed a commit that referenced this pull request May 2, 2025
jbrinkman added a commit that referenced this pull request May 5, 2025
jbrinkman added a commit that referenced this pull request May 5, 2025
This reverts commit 01db2a1.
Signed-off-by: jbrinkman <joe.brinkman@improving.com>
jbrinkman added a commit that referenced this pull request May 5, 2025
* Revert "Go: Fix Ordering of Sorted Set With Scores Commands (#3712)"

This reverts commit 01db2a1.
Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Fix broken dependencies during Go backport to 1.3.3

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Skip failing tests

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Revert "Go: Fix Rust static binary size (#3507)"

This reverts commit 0203cda.

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

# Conflicts:
#	CHANGELOG.md

---------

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go 🏃 golang wrapper

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants