Skip to content

Python: Moved the tests folder to be under the root folder - #3661

Merged
barshaul merged 2 commits into
valkey-io:mainfrom
barshaul:refactor_py_tests_structure
Apr 24, 2025
Merged

barshaul merged 2 commits into
valkey-io:mainfrom
barshaul:refactor_py_tests_structure

Conversation

@barshaul

@barshaul barshaul commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator

Move tests/ (and conftest.py) to the top-level python/ directory, alongside pytest.ini, in order to enable running tests from the root python folder with the conftest arguments.
Current struct:

python/
├── pytest.ini
└── python/
    ├── glide/
    └── tests/
        └── conftest.py

Refactored struct:

python/
├── pytest.ini
├── tests/
    ├── conftest.py
└── python/
    ├── glide/

Issue link

This Pull Request is linked to issue (URL): #3663

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@barshaul
barshaul force-pushed the refactor_py_tests_structure branch 2 times, most recently from 86b028a to a657daa Compare April 24, 2025 07:36
@barshaul
barshaul marked this pull request as ready for review April 24, 2025 07:40
@barshaul
barshaul requested a review from a team as a code owner April 24, 2025 07:40
Signed-off-by: barshaul <barshaul@amazon.com>
@barshaul
barshaul force-pushed the refactor_py_tests_structure branch from a657daa to 51cf638 Compare April 24, 2025 07:44
@barshaul
barshaul requested a review from shohamazon April 24, 2025 07:48
Signed-off-by: barshaul <barshaul@amazon.com>
@barshaul
barshaul force-pushed the refactor_py_tests_structure branch from 0090ed7 to f817888 Compare April 24, 2025 07:53

@shohamazon shohamazon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪

@barshaul
barshaul merged commit 0599e86 into valkey-io:main Apr 24, 2025
ikolomi pushed a commit that referenced this pull request May 11, 2025
* Python: Moved the tests folder to be under the root folder

Signed-off-by: barshaul <barshaul@amazon.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
* Python: Moved the tests folder to be under the root folder

Signed-off-by: barshaul <barshaul@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants