Go: Add command FUNCTION DELETE by jonathanl-bq · Pull Request #3603 · valkey-io/valkey-glide

jonathanl-bq · 2025-04-14T21:50:54Z

Issue link

This Pull Request is linked to issue (URL): #3480

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

tjzhang-BQ

looks good to me

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

* Implement FUNCTION DELETE command for Go client Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Remove extra line added to standalone tests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update CHANGELOG Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix typo causing build error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Add missing client call Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix build errors in integTests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix unit tests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Use correct version of FunctionDelete in cluster with route unit test Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Check against correct error type in integTests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Remove unused deleteResult variables Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Run formatter Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> --------- Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq added the go 🏃 golang wrapper label Apr 14, 2025

jonathanl-bq had a problem deploying to AWS_ACTIONS April 14, 2025 21:51 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 14, 2025 21:53 — with GitHub Actions Error

jonathanl-bq force-pushed the go/ulojonat-funcdelete branch from a345f79 to 548f742 Compare April 14, 2025 22:04

jonathanl-bq had a problem deploying to AWS_ACTIONS April 14, 2025 22:04 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 14, 2025 23:47 — with GitHub Actions Error

jonathanl-bq force-pushed the go/ulojonat-funcdelete branch from de7bfd3 to 7056054 Compare April 14, 2025 23:54

jonathanl-bq had a problem deploying to AWS_ACTIONS April 14, 2025 23:54 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 15, 2025 00:44 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 15, 2025 01:01 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 15, 2025 03:18 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 15, 2025 03:29 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 15, 2025 23:36 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 15, 2025 23:51 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 16, 2025 00:06 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 16, 2025 00:23 — with GitHub Actions Error

jonathanl-bq marked this pull request as ready for review April 16, 2025 00:23

jonathanl-bq requested a review from a team as a code owner April 16, 2025 00:23

Yury-Fridlyand approved these changes Apr 16, 2025

View reviewed changes

jonathanl-bq changed the title ~~Add command FUNCTION DELETE~~ Go: Add command FUNCTION DELETE Apr 16, 2025

tjzhang-BQ approved these changes Apr 16, 2025

View reviewed changes

jonathanl-bq temporarily deployed to AWS_ACTIONS April 16, 2025 17:23 — with GitHub Actions Inactive

jonathanl-bq force-pushed the go/ulojonat-funcdelete branch from d816fc4 to fbde285 Compare April 16, 2025 22:03

jonathanl-bq had a problem deploying to AWS_ACTIONS April 16, 2025 22:03 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS April 16, 2025 22:03 — with GitHub Actions Failure

jonathanl-bq force-pushed the go/ulojonat-funcdelete branch from fbde285 to 491e720 Compare April 16, 2025 22:12

jonathanl-bq had a problem deploying to AWS_ACTIONS April 16, 2025 22:13 — with GitHub Actions Error

Implement FUNCTION DELETE command for Go client

9da8564

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq added 10 commits April 16, 2025 15:40

Remove extra line added to standalone tests

94d673d

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Update CHANGELOG

dc8a75e

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Fix typo causing build error

a0e9bed

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Add missing client call

19af127

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Fix build errors in integTests

6f61cbb

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Fix unit tests

35bdfa9

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Use correct version of FunctionDelete in cluster with route unit test

bf5530b

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Check against correct error type in integTests

1c50c2f

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Remove unused deleteResult variables

bc65a39

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Run formatter

9f94ba6

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq force-pushed the go/ulojonat-funcdelete branch from 491e720 to 9f94ba6 Compare April 16, 2025 22:42

jonathanl-bq temporarily deployed to AWS_ACTIONS April 16, 2025 22:42 — with GitHub Actions Inactive

jonathanl-bq merged commit 9d250a9 into main Apr 16, 2025

yipin-chen mentioned this pull request Apr 19, 2025

Go: Function commands #3480

Closed

12 tasks

Navigation Menu

Uh oh!

Go: Add command FUNCTION DELETE - #3603

Go: Add command FUNCTION DELETE#3603
jonathanl-bq merged 11 commits into
mainfrom
go/ulojonat-funcdelete

jonathanl-bq commented Apr 14, 2025 •

edited

Loading

Uh oh!

tjzhang-BQ left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jonathanl-bq commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue link

Checklist

Uh oh!

tjzhang-BQ left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonathanl-bq commented Apr 14, 2025 •

edited

Loading