Skip to content

Go: Add GeoHash - #3439

Merged
prateek-kumar-improving merged 6 commits into
mainfrom
go/geo-hash-command
Mar 24, 2025
Merged

Go: Add GeoHash#3439
prateek-kumar-improving merged 6 commits into
mainfrom
go/geo-hash-command

Conversation

@prateek-kumar-improving

@prateek-kumar-improving prateek-kumar-improving commented Mar 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue link

This Pull Request is linked to issue (URL): #3365

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@prateek-kumar-improving
Go: Add Geo hash command
fb2c191 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
prateek-kumar-improving requested a review from a team as a code owner March 24, 2025 05:04
@prateek-kumar-improving prateek-kumar-improving mentioned this pull request Mar 24, 2025
Closed
10 tasks
@prateek-kumar-improving
Go: update changlog.md
5dcfda3 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Go: Add GeoHash Examples
7825e30 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving prateek-kumar-improving changed the title Go: Add Geo hash command Go: Add Geo hash Mar 24, 2025
@prateek-kumar-improving prateek-kumar-improving changed the title Go: Add Geo hash Go: Add GeoHash Mar 24, 2025
tjzhang-BQ
tjzhang-BQ reviewed Mar 24, 2025
View reviewed changes
Comment thread go/api/base_client.go Outdated
tjzhang-BQ
tjzhang-BQ reviewed Mar 24, 2025
View reviewed changes
Comment thread go/api/base_client.go Outdated
tjzhang-BQ
tjzhang-BQ reviewed Mar 24, 2025
View reviewed changes
Comment thread go/api/base_client.go Outdated
@prateek-kumar-improving
Go: Fix review comments
b764625 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Merge branch 'main' into go/geo-hash-command
ac158a0 
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
jamesx-improving
jamesx-improving approved these changes Mar 24, 2025
View reviewed changes

@jamesx-improving jamesx-improving left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prateek-kumar-improving
prateek-kumar-improving merged commit d69301c into main Mar 24, 2025
@prateek-kumar-improving
prateek-kumar-improving deleted the go/geo-hash-command branch March 24, 2025 18:49
@Yury-Fridlyand Yury-Fridlyand added the go 🏃 golang wrapper label Mar 29, 2025
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Mar 30, 2025
@prateek-kumar-improving @liorsve
Go: Add GeoHash (valkey-io#3439)
90a607c 
* Go: Add Geo hash command

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
@prateek-kumar-improving
Go: Add GeoHash (#3439)
e7e70ef 
* Go: Add Geo hash command

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesx-improving jamesx-improving jamesx-improving approved these changes
+1 more reviewer
@tjzhang-BQ tjzhang-BQ tjzhang-BQ approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

go 🏃 golang wrapper

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prateek-kumar-improving @tjzhang-BQ @jamesx-improving @Yury-Fridlyand