Conversation
6 tasks
barshaul
force-pushed
the
ffi_ipc
branch
2 times, most recently
from
March 16, 2025 16:05
7c71bda to
45daae4
Compare
barshaul
changed the title
barshaul
marked this pull request as ready for review
March 17, 2025 12:44
There was a problem hiding this comment.
This lib actively uses protobuf, while C# client - doesn't.
So I see two variants there
- We will be having 2 FFI interfaces
- Rework golang bindings to avoid using protobuf
There was a problem hiding this comment.
Need to clean up some code comments which refer to golang
Collaborator
Author
There was a problem hiding this comment.
- If 2 isn't possible, put protobuf functions under a feature flag. Please do it in the C# implementation.
| working-directory: ffi | ||
| run: | | ||
| cargo build --release | ||
| - name: Generate the C header file |
There was a problem hiding this comment.
It is needed for go client only and does not test the code
Collaborator
Author
There was a problem hiding this comment.
it isn't go-specific, it can be used in other FFI wrappers as well (C++ for example)
eifrah-aws
requested changes
Mar 17, 2025
Signed-off-by: barshaul <barshaul@amazon.com>
Signed-off-by: barshaul <barshaul@amazon.com>
eifrah-aws
requested changes
Mar 24, 2025
eifrah-aws
approved these changes
Mar 24, 2025
Signed-off-by: barshaul <barshaul@amazon.com>
Collaborator
|
Sorry I missed reviewing this PR. Only comment I have is: I made the decision to compile to |
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Mar 30, 2025
…key-io#3372) * Go/Core Refactore: Move FFI to a dedicated folder to be reusable for other wrappers Signed-off-by: barshaul <barshaul@amazon.com>
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
* Go/Core Refactore: Move FFI to a dedicated folder to be reusable for other wrappers Signed-off-by: barshaul <barshaul@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relocates the FFI interface from the Go folder to a dedicated ffi folder, making it reusable for other language wrappers.
Currently, the FFI C-Rust implementation is located under the Go folder since it has only been used for Go. However, as we expand support for additional wrappers, such as the C# and Python Sync clients, which will communicate via FFI instead of UDS, we need to move the logic out of the Go folder to improve reusability and maintainability.
Issue link
This Pull Request is linked to issue (URL): #3373
Checklist
Before submitting the PR make sure the following are checked: