Skip to content

Go: Implement FlushAll, FlushDB commands - #3117

Merged
Yury-Fridlyand merged 18 commits into
valkey-io:mainfrom
niharikabhavaraju:niharika-flushall
Mar 20, 2025
Merged

Yury-Fridlyand merged 18 commits into
valkey-io:mainfrom
niharikabhavaraju:niharika-flushall

Conversation

@niharikabhavaraju

@niharikabhavaraju niharikabhavaraju commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

Go: Implement FlushAll, FlushDB commands

Issue link

This Pull Request is linked to issue : #3396

Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
@niharikabhavaraju
niharikabhavaraju requested a review from a team as a code owner February 10, 2025 11:50
@niharikabhavaraju niharikabhavaraju self-assigned this Feb 10, 2025
niharikabhavaraju and others added 3 commits February 10, 2025 17:20
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
@niharikabhavaraju niharikabhavaraju changed the title Go: Implement FlushAll command Go: Implement FlushAll, FlushDB commands Feb 10, 2025
@Yury-Fridlyand Yury-Fridlyand added the go 🏃 golang wrapper label Feb 10, 2025
Comment thread go/api/glide_cluster_client.go Outdated
Comment thread go/api/glide_client.go Outdated
Comment thread go/api/glide_client.go Outdated
Comment thread go/api/glide_client.go Outdated
Comment thread go/api/glide_client.go Outdated
Comment thread go/api/glide_cluster_client.go Outdated
Comment thread go/api/glide_cluster_client.go Outdated
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Comment thread go/api/server_management_cluster_commands.go
Comment thread go/api/server_management_cluster_commands_test.go
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>

@Yury-Fridlyand Yury-Fridlyand left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Comment thread go/api/glide_cluster_client.go
Comment thread go/api/glide_cluster_client.go
@Yury-Fridlyand

Copy link
Copy Markdown

Please add changelog and fix PR description (needs a link to an issue)

Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
@niharikabhavaraju

Copy link
Copy Markdown
Contributor Author

Please add changelog and fix PR description (needs a link to an issue)

Added changelog, cant find issue link for server management commands , is the issue need to be created? @Yury-Fridlyand

@Yury-Fridlyand

Yury-Fridlyand commented Mar 19, 2025

Copy link
Copy Markdown

is the issue need to be created? @Yury-Fridlyand

Probably, please refer to existing ones and organize new issue(s) the same way

@jbrinkman jbrinkman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Yury-Fridlyand Yury-Fridlyand left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Yury-Fridlyand
Yury-Fridlyand merged commit f8da0c9 into valkey-io:main Mar 20, 2025
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Mar 30, 2025
* Implement FlushAll command
* Implemented FlushDB command

---------

Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
mo-amzn pushed a commit to mo-amzn/valkey-glide that referenced this pull request Apr 23, 2025
* Implement FlushAll command
* Implemented FlushDB command

---------

Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
* Implement FlushAll command
* Implemented FlushDB command

---------

Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go 🏃 golang wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants