Java: Shadow protobuf dependency by Yury-Fridlyand · Pull Request #2931 · valkey-io/valkey-glide

Yury-Fridlyand · 2025-01-09T01:21:41Z

Shadow dependency
Build artifact for publishing and testing
Use artifact in tests
Validate dependencies

./gradlew publishToMavenLocal

publishes package to the local maven cache using default version:

$> ls -1 ~/.m2/repository/io/valkey/valkey-glide/255.255.255/
valkey-glide-255.255.255-javadoc.jar
valkey-glide-255.255.255-linux-x86_64.jar
valkey-glide-255.255.255-sources.jar
valkey-glide-255.255.255.module
valkey-glide-255.255.255.pom

There are these files:
valkey-glide-255.255.255.module.txt
valkey-glide-255.255.255.pom.txt
valkey-glide-255.255.255-javadoc.zip
valkey-glide-255.255.255-linux-x86_64.zip
valkey-glide-255.255.255-sources.zip
(I changed the extensions, because GH does not allow to upload jar and others)

Issue link

This Pull Request is linked to issue (URL): #2804
Fixes #2947 and #2961

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Commits will be squashed upon merging.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand · 2025-01-10T03:08:44Z

fix publication

yipin-chen

LGTM, since you also include netty dependency, do you consider changing the title of this PR to `Java: Shadow protobuf and netty dependencies"?

Yury-Fridlyand · 2025-01-10T19:58:07Z

include netty dependency

I don't include it. Should I?

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

ikolomi · 2025-01-16T17:46:23Z

@Yury-Fridlyand why there are these file attachment to this PR (the zip files)?

ikolomi · 2025-01-16T17:49:56Z

                  distribution: "temurin"
                  java-version: 11

+            - name: Install protoc (protobuf)


how come shadowing java bindings has an effect on ORT third party tool?

I changed IT to use the generated module instead of client sources. Without these changes, ORT tool was failing:

02:36:38.314 [DefaultDispatcher-worker-2] ERROR org.ossreviewtoolkit.plugins.packagemanagers.gradleinspector.GradleInspector - Could not find io.valkey:valkey-glide:255.255.255. Searched in the following locations: - https://repo.maven.apache.org/maven2/io/valkey/valkey-glide/255.255.255/valkey-glide-255.255.255.pom - file:/home/runner/.m2/repository/io/valkey/valkey-glide/255.255.255/valkey-glide-255.255.255.pom from project :integTest. 02:36:38.322 [DefaultDispatcher-worker-2] ERROR org.ossreviewtoolkit.plugins.packagemanagers.gradleinspector.GradleInspector - Could not find io.valkey:valkey-glide:255.255.255 from project :integTest.

Yury-Fridlyand · 2025-01-16T17:51:36Z

@Yury-Fridlyand why there are these file attachment to this PR (the zip files)?

In order to review and verify the updated java client module.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Edward Liang <edward.liang@improving.com>

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Edward Liang <edward.liang@improving.com>

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Shadow protobuf

b35c592

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand added java ☕ issues and fixes related to the java client dependency labels Jan 9, 2025

Yury-Fridlyand requested a review from a team as a code owner January 9, 2025 01:21

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 9, 2025 01:21 — with GitHub Actions Failure

modules

8aad5da

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 9, 2025 02:02 — with GitHub Actions Failure

fix

576a6b5

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS January 9, 2025 02:31 — with GitHub Actions Inactive

ort

91f9de8

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 9, 2025 19:24 — with GitHub Actions Error

refactor

3453294

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS January 9, 2025 19:42 — with GitHub Actions Inactive

fixes

1c76e3a

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS January 9, 2025 23:33 — with GitHub Actions Inactive

ut

3b6e01f

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 9, 2025 23:55 — with GitHub Actions Error

fix

94ee1aa

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 10, 2025 00:16 — with GitHub Actions Error

fix

a76b519

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS January 10, 2025 00:40 — with GitHub Actions Inactive

yipin-chen approved these changes Jan 10, 2025

View reviewed changes

jonathanl-bq approved these changes Jan 10, 2025

View reviewed changes

Yury-Fridlyand marked this pull request as draft January 10, 2025 19:57

fixes

90489cb

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 10, 2025 21:02 — with GitHub Actions Error

fixes

a94cca1

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand temporarily deployed to AWS_ACTIONS January 10, 2025 21:15 — with GitHub Actions Inactive

Yury-Fridlyand requested review from eifrah-aws and ikolomi January 10, 2025 21:17

Yury-Fridlyand marked this pull request as ready for review January 10, 2025 21:28

Yury-Fridlyand linked an issue Jan 13, 2025 that may be closed by this pull request

User request: shadow protobuf dependency in java client #2947

Closed

2 tasks

yipin-chen requested a review from avifenesh January 14, 2025 06:25

ikolomi reviewed Jan 16, 2025

View reviewed changes

Yury-Fridlyand linked an issue Jan 16, 2025 that may be closed by this pull request

Protobuf 3.25.5 support for Quarkus Compatibility #2961

Closed

Merge branch 'main' into java/shadow

ab6bada

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 16, 2025 22:57 — with GitHub Actions Error

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 16, 2025 23:24 — with GitHub Actions Error

Yury-Fridlyand had a problem deploying to AWS_ACTIONS January 16, 2025 23:46 — with GitHub Actions Error

Yury-Fridlyand temporarily deployed to AWS_ACTIONS January 17, 2025 00:34 — with GitHub Actions Inactive

Yury-Fridlyand merged commit 65667f4 into main Jan 17, 2025

Yury-Fridlyand deleted the java/shadow branch January 17, 2025 21:32

Maayanshani25 pushed a commit to Maayanshani25/valkey-glide that referenced this pull request Jan 19, 2025

Java: Shadow protobuf dependency (valkey-io#2931)

ea9d1aa

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

edlng pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jan 20, 2025

Java: Shadow protobuf dependency (valkey-io#2931)

a5fbce5

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Edward Liang <edward.liang@improving.com>

Yury-Fridlyand mentioned this pull request Jan 24, 2025

Java: Shadow netty dependencies. - breaking change #3004

Merged

12 tasks

barshaul pushed a commit to barshaul/glide-for-redis that referenced this pull request Jan 28, 2025

Java: Shadow protobuf dependency (valkey-io#2931)

6d8c7cd

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

prateek-kumar-improving mentioned this pull request Mar 20, 2025

Conflict in internal netty and protobuf valkey-glide dependencies #3402

Closed

liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Mar 30, 2025

Java: Shadow protobuf dependency (valkey-io#2931)

9aa7cf2

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

affonsov pushed a commit that referenced this pull request Aug 21, 2026

Java: Shadow protobuf dependency (#2931)

5815074

* Shadow protobuf Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Navigation Menu

Uh oh!

Java: Shadow protobuf dependency - #2931

Java: Shadow protobuf dependency#2931
Yury-Fridlyand merged 12 commits into
mainfrom
java/shadow

Yury-Fridlyand commented Jan 9, 2025 •

edited

Loading

Uh oh!

Yury-Fridlyand commented Jan 10, 2025

Uh oh!

yipin-chen left a comment

Uh oh!

Yury-Fridlyand commented Jan 10, 2025 •

edited

Loading

Uh oh!

ikolomi commented Jan 16, 2025

Uh oh!

ikolomi Jan 16, 2025

Uh oh!

Yury-Fridlyand Jan 16, 2025

Uh oh!

Yury-Fridlyand commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Yury-Fridlyand commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue link

Checklist

Uh oh!

Yury-Fridlyand commented Jan 10, 2025

Uh oh!

yipin-chen left a comment

Choose a reason for hiding this comment

Uh oh!

Yury-Fridlyand commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikolomi commented Jan 16, 2025

Uh oh!

ikolomi Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

Yury-Fridlyand Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

Yury-Fridlyand commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Yury-Fridlyand commented Jan 9, 2025 •

edited

Loading

Yury-Fridlyand commented Jan 10, 2025 •

edited

Loading