Update CONFIG GET and CONFIG SET documentation and tests by jonathanl-bq · Pull Request #2919 · valkey-io/valkey-glide

jonathanl-bq · 2025-01-07T00:41:54Z

Issue link

This Pull Request is linked to issue (URL): #2192

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

…client Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

…meters Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Signed-off-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

…le config error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Yury-Fridlyand · 2025-01-08T23:37:36Z

+        async (protocol) => {
+            await runTest(async (client: BaseClient, cluster) => {
+                if (cluster.checkIfServerVersionLessThan("7.0.0")) {
+                    return;


Optional: You can check that server returns an error on version < 7

tjzhang-BQ

lgtm with comments resolved

yipin-chen

LGTM

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

* Update documentation for CONFIG GET and CONFIG SET commands for Java client Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update documentation for BaseTransaction CONFIG GET and CONFIG SET Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Add transaction test for CONFIG SET and CONFIG GET with multiple parameters Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update Python client CONFIG SET and CONFIG GET docs and tests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update Python transaction CONFIG GET and CONFIG SET docs Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update Node client docs and tests for CONFIG SET and CONFIG GET Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update CHANGELOG Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix linter issue Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix Prettier issues Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Apply Spotless Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Add missing cluster argument for Node SharedTests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Try changing cluster-node-timeout instead of logfile to avoid immutable config error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix test failures for Node client Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix linting errors Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Sort expected result for CONFIG GET and CONFIG SET transaction test Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Assign sorted array to new variable Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Apply Black linter Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update Python tests to avoid immutable config error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Apply Black linter Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix typo Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix typo in Python tests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Run Black linter Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix failing Node test Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Remove swap file Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Combine CONFIG GET and CONFIG SET tests in SharedTests.ts Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix build error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> --------- Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> Signed-off-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>

) * Update documentation for CONFIG GET and CONFIG SET commands for Java client Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update documentation for BaseTransaction CONFIG GET and CONFIG SET Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Add transaction test for CONFIG SET and CONFIG GET with multiple parameters Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update Python client CONFIG SET and CONFIG GET docs and tests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update Python transaction CONFIG GET and CONFIG SET docs Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update Node client docs and tests for CONFIG SET and CONFIG GET Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update CHANGELOG Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix linter issue Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix Prettier issues Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Apply Spotless Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Add missing cluster argument for Node SharedTests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Try changing cluster-node-timeout instead of logfile to avoid immutable config error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix test failures for Node client Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix linting errors Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Sort expected result for CONFIG GET and CONFIG SET transaction test Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Assign sorted array to new variable Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Apply Black linter Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Update Python tests to avoid immutable config error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Apply Black linter Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix typo Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix typo in Python tests Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Run Black linter Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix failing Node test Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Remove swap file Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Combine CONFIG GET and CONFIG SET tests in SharedTests.ts Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> * Fix build error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> --------- Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> Signed-off-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>

jonathanl-bq added 6 commits January 5, 2025 22:50

Update documentation for CONFIG GET and CONFIG SET commands for Java …

8339482

…client Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Update documentation for BaseTransaction CONFIG GET and CONFIG SET

e58bfd6

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Add transaction test for CONFIG SET and CONFIG GET with multiple para…

2c4cca3

…meters Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Update Python client CONFIG SET and CONFIG GET docs and tests

ff274c8

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Update Python transaction CONFIG GET and CONFIG SET docs

accc928

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Update Node client docs and tests for CONFIG SET and CONFIG GET

e9aa5f2

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq had a problem deploying to AWS_ACTIONS January 7, 2025 00:42 — with GitHub Actions Error

jonathanl-bq and others added 3 commits January 6, 2025 16:44

Update CHANGELOG

03df33e

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Fix linter issue

57b80eb

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Merge branch 'main' into update-config-get-config-set-docs

296d5cc

Signed-off-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>

jonathanl-bq had a problem deploying to AWS_ACTIONS January 7, 2025 00:47 — with GitHub Actions Error

Fix Prettier issues

94967ef

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq had a problem deploying to AWS_ACTIONS January 7, 2025 00:54 — with GitHub Actions Error

Apply Spotless

8fd4ad2

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq had a problem deploying to AWS_ACTIONS January 7, 2025 01:18 — with GitHub Actions Error

Add missing cluster argument for Node SharedTests

f9a38a3

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq had a problem deploying to AWS_ACTIONS January 7, 2025 19:27 — with GitHub Actions Error

Try changing cluster-node-timeout instead of logfile to avoid immutab…

b75e286

…le config error Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq had a problem deploying to AWS_ACTIONS January 7, 2025 22:21 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS January 8, 2025 22:09 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS January 8, 2025 22:33 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS January 8, 2025 23:08 — with GitHub Actions Error

jonathanl-bq marked this pull request as ready for review January 8, 2025 23:08

jonathanl-bq requested a review from a team as a code owner January 8, 2025 23:08

jonathanl-bq requested a review from Yury-Fridlyand January 8, 2025 23:08

jonathanl-bq had a problem deploying to AWS_ACTIONS January 8, 2025 23:33 — with GitHub Actions Error

Yury-Fridlyand approved these changes Jan 8, 2025

View reviewed changes

Yury-Fridlyand added the docs 📖 Documentation label Jan 8, 2025

tjzhang-BQ approved these changes Jan 9, 2025

View reviewed changes

yipin-chen approved these changes Jan 9, 2025

View reviewed changes

jonathanl-bq added 2 commits January 9, 2025 09:50

Remove swap file

9baf9f4

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

Combine CONFIG GET and CONFIG SET tests in SharedTests.ts

13604e8

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq had a problem deploying to AWS_ACTIONS January 9, 2025 18:07 — with GitHub Actions Error

Fix build error

a007819

Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com>

jonathanl-bq had a problem deploying to AWS_ACTIONS January 9, 2025 18:29 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS January 9, 2025 18:29 — with GitHub Actions Failure

jonathanl-bq had a problem deploying to AWS_ACTIONS January 9, 2025 18:29 — with GitHub Actions Error

jonathanl-bq had a problem deploying to AWS_ACTIONS January 9, 2025 19:00 — with GitHub Actions Failure

jonathanl-bq had a problem deploying to AWS_ACTIONS January 10, 2025 01:03 — with GitHub Actions Failure

jonathanl-bq merged commit 52b51dc into main Jan 10, 2025

yipin-chen mentioned this pull request Jan 11, 2025

Update docs for CONFIG SET and CONFIG GET #2192

Closed

2 tasks

Yury-Fridlyand deleted the update-config-get-config-set-docs branch February 24, 2025 17:14

Navigation Menu

Uh oh!

Update CONFIG GET and CONFIG SET documentation and tests - #2919

Update CONFIG GET and CONFIG SET documentation and tests#2919
jonathanl-bq merged 27 commits into
mainfrom
update-config-get-config-set-docs

jonathanl-bq commented Jan 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Yury-Fridlyand Jan 8, 2025

Uh oh!

tjzhang-BQ left a comment

Uh oh!

yipin-chen left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jonathanl-bq commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue link

Checklist

Uh oh!

Uh oh!

Uh oh!

Yury-Fridlyand Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

tjzhang-BQ left a comment

Choose a reason for hiding this comment

Uh oh!

yipin-chen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonathanl-bq commented Jan 7, 2025 •

edited

Loading