Ensure cluster client creation fail when engine is < 7.0 and sharded subscriptions are configured - #2819
Merged
Conversation
ikolomi
marked this pull request as draft
December 15, 2024 22:30
ikolomi
force-pushed
the
fix_sharded_subs
branch
from
December 16, 2024 11:58
154bf4a to
11e080c
Compare
ikolomi
force-pushed
the
fix_sharded_subs
branch
from
December 16, 2024 12:00
11e080c to
4045f8f
Compare
ikolomi
marked this pull request as ready for review
December 16, 2024 12:01
ikolomi
force-pushed
the
fix_sharded_subs
branch
from
December 16, 2024 18:32
4045f8f to
c4c7dcd
Compare
eifrah-aws
approved these changes
Dec 17, 2024
…nfigured Signed-off-by: ikolomi <ikolomin@amazon.com>
ikolomi
force-pushed
the
fix_sharded_subs
branch
from
December 17, 2024 11:38
c4c7dcd to
a6e76f8
Compare
ikolomi
had a problem deploying
to
AWS_ACTIONS
December 17, 2024 11:38 — with 
GitHub Actions
Failure
GitHub Actions
Failure
ikolomi
had a problem deploying
to
AWS_ACTIONS
December 17, 2024 11:38 — with
GitHub Actions
Failure
GitHub Actions
Failure
ikolomi
had a problem deploying
to
AWS_ACTIONS
December 17, 2024 11:38 — with
GitHub Actions
Failure
GitHub Actions
Failure
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Mar 30, 2025
…subscriptions are configured (valkey-io#2819) Introduce engine version validation when sharded subscriptions are configured Signed-off-by: ikolomi <ikolomin@amazon.com>
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
…subscriptions are configured (#2819) Introduce engine version validation when sharded subscriptions are configured Signed-off-by: ikolomi <ikolomin@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #1678
Checklist
Before submitting the PR make sure the following are checked: