Skip to content

[backport to 1.2] Bump protoc - #2561

Merged
Yury-Fridlyand merged 12 commits into
valkey-io:release-1.2from
Bit-Quill:protoc-update
Dec 6, 2024
Merged

Yury-Fridlyand merged 12 commits into
valkey-io:release-1.2from
Bit-Quill:protoc-update

Conversation

@Yury-Fridlyand

@Yury-Fridlyand Yury-Fridlyand commented Oct 31, 2024

Copy link
Copy Markdown

Backport #2421 to 1.2
Depends on and includes #2782

Update protoc to most recent version.

Issue link

Closes #2650

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added python 🐍 Python wrapper java ☕ issues and fixes related to the java client protobuf labels Oct 31, 2024
@Yury-Fridlyand
Yury-Fridlyand requested a review from a team as a code owner October 31, 2024 20:54
Comment thread python/requirements.txt Outdated
@acarbonetto acarbonetto changed the title Bump protoc [backport to 1.2] Bump protoc Nov 1, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand linked an issue Nov 15, 2024 that may be closed by this pull request
2 tasks
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

@acarbonetto acarbonetto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can allow python users to use 3.25.5 as it addresses the vulnerability.
And java 28.2 is the version to use.

Comment thread .github/workflows/pypi-cd.yml Outdated
Comment thread CHANGELOG.md Outdated
Comment thread .github/workflows/java-cd.yml Outdated
Comment thread .github/workflows/java-cd.yml Outdated
Comment thread .github/workflows/java.yml Outdated
Comment thread java/DEVELOPER.md Outdated
Comment thread java/DEVELOPER.md Outdated
Comment thread java/client/build.gradle Outdated
Comment thread python/DEVELOPER.md Outdated
Comment thread python/requirements.txt Outdated
Comment thread .github/workflows/pypi-cd.yml Outdated
Comment thread java/DEVELOPER.md Outdated
Comment thread java/DEVELOPER.md Outdated
Comment thread python/DEVELOPER.md Outdated
Comment thread python/DEVELOPER.md Outdated
Yury-Fridlyand and others added 4 commits November 20, 2024 17:12
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand removed the python 🐍 Python wrapper label Nov 21, 2024
@Yury-Fridlyand

Yury-Fridlyand commented Nov 21, 2024

Copy link
Copy Markdown
Author

I reverted all changes for python 🐍

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Yury-Fridlyand merged commit c99f30b into valkey-io:release-1.2 Dec 6, 2024
@Yury-Fridlyand
Yury-Fridlyand deleted the protoc-update branch December 6, 2024 18:48
Yury-Fridlyand added a commit to Bit-Quill/valkey-glide that referenced this pull request Dec 10, 2024
* Bump protoc

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
yipin-chen pushed a commit that referenced this pull request Dec 10, 2024
[backport to 1.2] Bump protoc (#2561)

* Bump protoc

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Yury-Fridlyand added a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 6, 2025
* Bump protoc

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
[backport to 1.2] Bump protoc (#2561)

* Bump protoc

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
* Bump protoc

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java ☕ issues and fixes related to the java client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump protobuf and protoc versions

5 participants