Node: add command JSON.NUMINCRBY and JSON.NUMMULTBY - #2555
Merged
Merged
Conversation
tjzhang-BQ
had a problem deploying
to
AWS_ACTIONS
October 31, 2024 01:56 — with 
GitHub Actions
Error
GitHub Actions
Error
tjzhang-BQ
marked this pull request as ready for review
October 31, 2024 02:09
tjzhang-BQ
temporarily deployed
to
AWS_ACTIONS
October 31, 2024 02:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
11 tasks
tjzhang-BQ
force-pushed
the
node/tjz-jsonnumincrby
branch
from
October 31, 2024 22:08
c9676f5 to
49f9dd9
Compare
tjzhang-BQ
temporarily deployed
to
AWS_ACTIONS
October 31, 2024 22:08 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jonathanl-bq
reviewed
Nov 2, 2024
Contributor
Author
memdb tests
|
jonathanl-bq
approved these changes
Nov 4, 2024
Yury-Fridlyand
approved these changes
Nov 5, 2024
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
I feel like we need to do value conversion and return number | number[] from this function.
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
tjzhang-BQ
force-pushed
the
node/tjz-jsonnumincrby
branch
from
November 7, 2024 18:57
8382619 to
11bb57b
Compare
tjzhang-BQ
temporarily deployed
to
AWS_ACTIONS
November 7, 2024 18:57 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
Signed-off-by: TJ Zhang <tj.zhang@improving.com> Co-authored-by: TJ Zhang <tj.zhang@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2375
Checklist
Before submitting the PR make sure the following are checked: