Skip to content

Node: add ARRTRIM command - #2550

Merged
Yury-Fridlyand merged 9 commits into
release-1.2from
node/yipin-valkey-456
Oct 31, 2024
Merged

Node: add ARRTRIM command#2550
Yury-Fridlyand merged 9 commits into
release-1.2from
node/yipin-valkey-456

Conversation

@yipin-chen

@yipin-chen yipin-chen commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue link

#2529

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@yipin-chen
Node: add ARRTRIM command
cdcdd52 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen added the node 🐢 Node.js wrapper label Oct 30, 2024
@yipin-chen
Merge branch 'release-1.2' into node/yipin-valkey-456
acfc85a 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Updated CHANGELOG
176bd73 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Fixed IT
086bdc2 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Fixed empty array test
9cc7856 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
yipin-chen marked this pull request as ready for review October 30, 2024 23:37
@yipin-chen
yipin-chen requested a review from a team as a code owner October 30, 2024 23:37
Yury-Fridlyand
Yury-Fridlyand approved these changes Oct 31, 2024
View reviewed changes
Comment thread node/src/server-modules/GlideJson.ts Outdated
Comment thread node/src/server-modules/GlideJson.ts Outdated
@yipin-chen
Addressed review comments
c1af58a 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Yury-Fridlyand
Yury-Fridlyand approved these changes Oct 31, 2024
View reviewed changes
Comment thread node/src/server-modules/GlideJson.ts Outdated
Comment thread node/src/server-modules/GlideJson.ts Outdated
Comment thread node/src/server-modules/GlideJson.ts Outdated
Comment thread node/src/server-modules/GlideJson.ts Outdated
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 31, 2024
Closed
11 tasks
@yipin-chen
Addressed review comments
8a9ccc7 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
jamesx-improving
jamesx-improving approved these changes Oct 31, 2024
View reviewed changes
Comment thread node/src/server-modules/GlideJson.ts Outdated
Comment thread node/src/server-modules/GlideJson.ts Outdated
* console.log(await GlideJson.get(client, "doc", "$"));
* // Output: '[[],["a"],["a","b"],["a","b"]]' - Returns the value at path '$' in the JSON document stored at `doc`.
* ```
* @example

@jamesx-improving jamesx-improving Oct 31, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 separated example sections? Why?

@yipin-chen yipin-chen Oct 31, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided two examples - one for enhanced syntax path and one for legacy path.

@Yury-Fridlyand
Yury-Fridlyand merged commit 23689db into release-1.2 Oct 31, 2024
@Yury-Fridlyand
Yury-Fridlyand deleted the node/yipin-valkey-456 branch October 31, 2024 23:07
adarovadya pushed a commit to adarovadya/glide-for-redis that referenced this pull request Nov 2, 2024
@yipin-chen Adar Ovadia
Node: add ARRTRIM command (valkey-io#2550)
eb33a24 
* Node: add ARRTRIM command

Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
@yipin-chen
Node: add ARRTRIM command (#2550)
557f1e4 
* Node: add ARRTRIM command

Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesx-improving jamesx-improving jamesx-improving approved these changes
+2 more reviewers
@jonathanl-bq jonathanl-bq jonathanl-bq approved these changes
@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

node 🐢 Node.js wrapper

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yipin-chen @jonathanl-bq @Yury-Fridlyand @jamesx-improving