Python: Add JSON.ARRINDEX Command - #2528

Merged

shohamazon merged 4 commits into

release-1.2from

Oct 30, 2024

mo-amzn commented Oct 27, 2024 •

edited

Loading

Collaborator

Issue link

This Pull Request is linked to issue (URL): #2412

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Commits will be squashed upon merging.

mo-amzn added python 🐍 1_2_candidate labels

mo-amzn requested a review from shohamazon

October 27, 2024 15:52

mo-amzn self-assigned this

mo-amzn requested a review from a team as a code owner

October 27, 2024 15:52

mo-amzn had a problem deploying to AWS_ACTIONS

October 27, 2024 15:52

— with

GitHub Actions Error

mo-amzn had a problem deploying to AWS_ACTIONS

October 27, 2024 15:54

— with

GitHub Actions Error

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon mentioned this pull request

Json module for Python #645

Closed

22 tasks

mo-amzn had a problem deploying to AWS_ACTIONS

October 28, 2024 13:42

— with

GitHub Actions Error

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py Outdated

mo-amzn had a problem deploying to AWS_ACTIONS

October 28, 2024 16:27

— with

GitHub Actions Error

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py

python/python/glide/async_commands/server_modules/json.py Outdated

python/python/glide/async_commands/server_modules/json.py Outdated

python/python/glide/async_commands/server_modules/json.py Outdated

python/python/glide/async_commands/server_modules/json.py Outdated

python/python/glide/async_commands/server_modules/json.py Outdated

python/python/tests/tests_server_modules/test_json.py Outdated

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/server_modules/json.py

python/python/glide/__init__.py

python/python/glide/async_commands/server_modules/json.py Outdated

python/python/glide/async_commands/server_modules/json.py

python/python/glide/async_commands/server_modules/json.py Outdated

python/python/tests/tests_server_modules/test_json.py

python/python/tests/tests_server_modules/test_json.py Outdated

python/python/tests/tests_server_modules/test_json.py Outdated

python/python/tests/tests_server_modules/test_json.py

python/python/tests/tests_server_modules/test_json.py

mo-amzn requested a review from shohamazon

October 30, 2024 10:19

mo-amzn added 2 commits

October 30, 2024 16:10


          Python: Add JSON.ARRINDEx Command

cdd3a32

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>


          Oredered the place of arrindex

fede07b

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>

mo-amzn force-pushed the json.arrindex branch from add3e29 to fede07b Compare

October 30, 2024 16:12

mo-amzn had a problem deploying to AWS_ACTIONS

October 30, 2024 16:13

— with

GitHub Actions Error


          Changed return type of to_args func

e8b7183

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>

mo-amzn had a problem deploying to AWS_ACTIONS

October 30, 2024 16:20

— with

GitHub Actions Error


          isort

e4da99b

Signed-off-by: Shoham Elias <shohame@amazon.com>

shohamazon temporarily deployed to AWS_ACTIONS

October 30, 2024 16:29

— with

GitHub Actions Inactive

shohamazon approved these changes

View reviewed changes

shohamazon merged commit 5b90096 into release-1.2

shohamazon deleted the json.arrindex branch

October 30, 2024 16:46

Yury-Fridlyand mentioned this pull request

Java: JSON.ARRINDEX #2546

Merged

6 tasks

adarovadya pushed a commit to adarovadya/glide-for-redis that referenced this pull request


          Python: Add JSON.ARRINDEX Command (valkey-io#2528)

15b0b41

---------

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Co-authored-by: Shoham Elias <shohame@amazon.com>

affonsov pushed a commit that referenced this pull request


          Python: Add JSON.ARRINDEX Command (#2528)

aedd2d4

---------

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Co-authored-by: Shoham Elias <shohame@amazon.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels