Skip to content

Python: Add FT.SEARCH command - #2470

Merged
acarbonetto merged 26 commits into
release-1.2from
python-ft-search-command
Oct 22, 2024
Merged

Python: Add FT.SEARCH command#2470
acarbonetto merged 26 commits into
release-1.2from
python-ft-search-command

Conversation

@prateek-kumar-improving

@prateek-kumar-improving prateek-kumar-improving commented Oct 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue link

This Pull Request is linked to issue (URL): #2429

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@prateek-kumar-improving
Python: Add FT.SEARCH command
b571a7f 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
prateek-kumar-improving requested a review from a team as a code owner October 17, 2024 01:39
@prateek-kumar-improving prateek-kumar-improving added the python 🐍 Python wrapper label Oct 17, 2024
@prateek-kumar-improving prateek-kumar-improving mentioned this pull request Oct 17, 2024
Closed
14 tasks
@prateek-kumar-improving prateek-kumar-improving changed the title Python: Add FT.SEARCH command Python: Add FT.SEARCH command Oct 17, 2024
@prateek-kumar-improving
Python FT.SEARCH - rust file removed
dc8d2c4 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python FT.SEARCH Rust file removed
560d165 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
acarbonetto
acarbonetto reviewed Oct 17, 2024
View reviewed changes
Comment thread python/python/glide/async_commands/server_modules/ft.py Outdated
Comment thread python/python/glide/async_commands/server_modules/ft.py Outdated
Comment thread python/python/tests/tests_server_modules/search/test_ft_search.py Outdated
Comment thread python/python/tests/tests_server_modules/search/test_ft_search.py Outdated
Comment thread python/python/tests/tests_server_modules/search/test_ft_search.py Outdated
Comment thread python/python/tests/tests_server_modules/search/test_ft_search.py Outdated
Comment thread python/python/tests/tests_server_modules/search/test_ft_search.py Outdated
Comment thread python/python/tests/tests_server_modules/search/test_ft_search.py Outdated
@prateek-kumar-improving
Merge branch 'release-1.2' into python-ft-search-command
fcec549 
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
@prateek-kumar-improving
Python FT.SEARCH review comments addressed
e937736 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Review comments fixed
67680e9 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Yury-Fridlyand
Yury-Fridlyand reviewed Oct 17, 2024
View reviewed changes
Comment thread python/python/glide/async_commands/server_modules/ft.py Outdated
Comment thread python/python/glide/async_commands/server_modules/ft_options/ft_search_options.py
Comment thread python/python/tests/tests_server_modules/search/test_ft_search.py
Comment thread python/python/tests/tests_server_modules/search/test_ft_search.py Outdated
@Yury-Fridlyand

Yury-Fridlyand commented Oct 17, 2024

Copy link
Copy Markdown

Add changelog please

@prateek-kumar-improving
Python: Review comments addressed
4d334f1 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
CHANGELOG.md updated
327faea 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python FT.SEARCH utils updated
c666d07 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python FT.SEARCH delete index after ft.search test
b06c1fe 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
acarbonetto
acarbonetto reviewed Oct 22, 2024
View reviewed changes
Comment thread python/python/glide/async_commands/server_modules/ft.py Outdated
acarbonetto
acarbonetto approved these changes Oct 22, 2024
View reviewed changes
Comment thread python/python/glide/async_commands/server_modules/ft_options/ft_constants.py Outdated
@prateek-kumar-improving
Python: update documentation
ca5f9f1 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python FT.SEARCH fix documenation
bb1b65d 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python FT.SEARCH fix documentation
ce312a5 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@acarbonetto
acarbonetto merged commit 9073eb0 into release-1.2 Oct 22, 2024
@acarbonetto
acarbonetto deleted the python-ft-search-command branch October 22, 2024 01:59
BoazBD pushed a commit to BoazBD/valkey-glide that referenced this pull request Oct 22, 2024
@prateek-kumar-improving @BoazBD
Python: Add FT.SEARCH command (valkey-io#2470)
1e8f312 
* Python: Add FT.SEARCH command
---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
mo-amzn pushed a commit to mo-amzn/valkey-glide that referenced this pull request Oct 22, 2024
@prateek-kumar-improving @mo-amzn
Python: Add FT.SEARCH command (valkey-io#2470)
1c64d38 
* Python: Add FT.SEARCH command
---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
mo-amzn pushed a commit to mo-amzn/valkey-glide that referenced this pull request Oct 22, 2024
@prateek-kumar-improving @mo-amzn
Python: Add FT.SEARCH command (valkey-io#2470)
e5ca02a 
* Python: Add FT.SEARCH command
---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
cyip10 pushed a commit that referenced this pull request Oct 23, 2024
@prateek-kumar-improving @cyip10
Python: Add FT.SEARCH command (#2470)
5a4944e 
* Python: Add FT.SEARCH command
---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
@prateek-kumar-improving
Python: Add FT.SEARCH command (#2470)
d0c0d2e 
* Python: Add FT.SEARCH command
---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shohamazon shohamazon Awaiting requested review from shohamazon
2 more reviewers
@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes
@acarbonetto acarbonetto acarbonetto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

python 🐍 Python wrapper

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prateek-kumar-improving @Yury-Fridlyand @acarbonetto