Python: adds JSON.ARRTRIM command - #2457
Merged
Merged
Conversation
shohamazon
temporarily deployed
to
AWS_ACTIONS
October 15, 2024 11:36 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
Code LGTM
Please fix CI, resolve conflicts and add changelog
Comment on lines
+204
to
+207
| Trims an array at the specified `path` within the JSON document stored at `key` so that it becomes a subarray [start, end], both inclusive.\n | ||
| If `start` < 0, it is treated as 0.\n | ||
| If `end` >= size (size of the array), it is treated as size-1.\n | ||
| If `start` >= size or `start` > `end`, the array is emptied and 0 is returned.\n |
Collaborator
Author
There was a problem hiding this comment.
it is more readable in the IDE
no \n:
Collaborator
Author
There was a problem hiding this comment.
let me know what you thing, removed for now
Signed-off-by: Shoham Elias <shohame@amazon.com>
shohamazon
force-pushed
the
python/json.arrtrim
branch
from
October 27, 2024 13:14
8b8bda5 to
8300273
Compare
shohamazon
temporarily deployed
to
AWS_ACTIONS
October 27, 2024 13:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Signed-off-by: Shoham Elias <shohame@amazon.com>
shohamazon
force-pushed
the
python/json.arrtrim
branch
from
October 27, 2024 13:24
8300273 to
ac7d8cf
Compare
shohamazon
temporarily deployed
to
AWS_ACTIONS
October 27, 2024 13:24 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
--------- Signed-off-by: Shoham Elias <shohame@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #645
Checklist
Before submitting the PR make sure the following are checked: