Skip to content

Rename stop to end in sorted set query. - #2214

Merged
Yury-Fridlyand merged 4 commits into
valkey-io:mainfrom
Bit-Quill:node/yuryf-rename-range
Sep 9, 2024
Merged

Yury-Fridlyand merged 4 commits into
valkey-io:mainfrom
Bit-Quill:node/yuryf-rename-range

Conversation

@Yury-Fridlyand

@Yury-Fridlyand Yury-Fridlyand commented Aug 30, 2024

Copy link
Copy Markdown

Rename range queries for sorted set commands (e.g. zrange, zrevrange, zremrange, etc) naming: start & stop to start & end

  • align with java
  • align with common sense

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added python 🐍 Python wrapper node 🐢 Node.js wrapper labels Aug 30, 2024
@Yury-Fridlyand
Yury-Fridlyand marked this pull request as ready for review August 30, 2024 01:51
@Yury-Fridlyand
Yury-Fridlyand requested a review from a team as a code owner August 30, 2024 01:51
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Yury-Fridlyand merged commit c8c5b83 into valkey-io:main Sep 9, 2024
@Yury-Fridlyand
Yury-Fridlyand deleted the node/yuryf-rename-range branch September 9, 2024 16:07
janhavigupta007 pushed a commit to janhavigupta007/glide-for-redis that referenced this pull request Sep 11, 2024
* Rename `stop` to `end` in sorted set query.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
affonsov pushed a commit that referenced this pull request Aug 21, 2026
* Rename `stop` to `end` in sorted set query.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

node 🐢 Node.js wrapper python 🐍 Python wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants